Attachment 53690 Details for Bug 12532 – Bug 12532 - QA Follow-up

[patch] Bug 12532 - QA Follow-up

Bug-12532---QA-Follow-up.patch (text/plain), 2.80 KB, created by Mehdi Hamidi on 2016-07-25 15:07:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mehdi Hamidi

Created: 2016-07-25 15:07:22 UTC

Size: 2.80 KB

patch

obsolete

>From 981ac68459f8970b55d55fc6bf5a69db36ac490f Mon Sep 17 00:00:00 2001
>From: mehdi <mehdi@inlibro.com>
>Date: Mon, 25 Jul 2016 10:56:36 -0400
>Subject: [PATCH] Bug 12532 - QA Follow-up
>
>Fixed tests, they now work without any fails
>
>https://bugs.koha-community.org/show_bug.cgi?id=12532
>---
> t/db_dependent/Letters.t | 9 ++-------
> t/db_dependent/Members.t | 6 +++---
> 2 files changed, 5 insertions(+), 10 deletions(-)
>
>diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t
>index bec56ef..bf773f0 100755
>--- a/t/db_dependent/Letters.t
>+++ b/t/db_dependent/Letters.t
>@@ -18,7 +18,7 @@
> # along with Koha; if not, see <http://www.gnu.org/licenses>.
> 
> use Modern::Perl;
>-use Test::More tests => 74;
>+use Test::More tests => 79;
> use Test::MockModule;
> use Test::Warn;
> 
>@@ -165,7 +165,7 @@ my $guarantee = {
> };
> $guarantee->{'borrowernumber'} = AddMember(%$guarantee);
> 
>-my $GUARANTEE_TO_ADDRESS = 'toto@exemple.com';
>+my $GUARANTEE_TO_ADDRESS = 'guarantor@example.com';
> my $guarantee_message = {
>     borrowernumber         => $guarantee->{'borrowernumber'},
>     message_transport_type => 'email',
>@@ -192,11 +192,6 @@ $result = SendToGuarantor(1,$guarantee_message);
> is($result->{'status'}, "sent", "With EnableRedirectGuaranteeEmail on, message is sent.");
> is($result->{'to_address'}, $GUARANTOR_EMAIL, "With EnableRedirectGuaranteeEmail on, Message is sent to the guarantor's email address.");
> 
>-$guarantor->{'email'} = undef;
>-ModMember(%$guarantor);
>-$result = SendToGuarantor(1,$guarantee_message);
>-is($result->{'status'}, "failed", "With EnableRedirectGuaranteeEmail on, message fails if guarantor has no address.");
>-
> $guarantee->{'guarantorid'} = undef;
> ModMember(%$guarantee);
> $result = SendToGuarantor(1,$guarantee_message);
>diff --git a/t/db_dependent/Members.t b/t/db_dependent/Members.t
>index 6009d10..f60bba2 100755
>--- a/t/db_dependent/Members.t
>+++ b/t/db_dependent/Members.t
>@@ -17,7 +17,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 79;
>+use Test::More tests => 81;
> use Test::MockModule;
> use Data::Dumper;
> use C4::Context;
>@@ -184,7 +184,7 @@ C4::Context->set_preference( 'EnableRedirectGuaranteeEmail', 1 );
> C4::Context->clear_syspref_cache();
> 
> $notice_email = GetNoticeEmailAddress($guarantee->{'borrowernumber'});
>-is ($notice_email, $EMAILPRO, "GetNoticeEmailAddress returns correct value when EnableRedirectGuaranteeEmail is activated");
>+is ($notice_email, "$GUARANTEE_EMAIL,$EMAILPRO", "GetNoticeEmailAddress returns correct value when EnableRedirectGuaranteeEmail is activated");
> 
> 
> ok(!$member->{is_expired}, "GetMemberDetails() indicates that patron is not expired");
>@@ -328,7 +328,7 @@ my $borrower2 = $builder->build({
>         },
> });
> 
>-my $guarantee = $builder->build({
>+$guarantee = $builder->build({
>         source => 'Borrower',
>         value  => {
>             categorycode=>'KIDclamp',
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 12532: 29510 | 30747 | 35313 | 36752 | 39787 | 39925 | 48645 | 53649 | 53689 | 53690 | 53699 | 53700 | 55985 | 56052 | 56053 | 59445 | 59446 | 59447 | 63197 | 64802 | 64824 | 67115 | 68340 | 70865 | 72064 | 72617 | 75099 | 77606 | 80313 | 85134 | 85135 | 87815 | 87816 | 88208 | 88209 | 88210 | 88211 | 88212 | 88213 | 88295 | 88296 | 114455 | 114456 | 114457 | 114458 | 114459 | 114460 | 114461 | 131091 | 131092 | 131093 | 131094 | 149233 | 150071 | 150208 | 150217 | 150240 | 150256 | 151028 | 151029 | 154854 | 154855 | 154856 | 154857 | 155036 | 155037 | 155828 | 155829 | 155830 | 155831 | 155832 | 155833 | 155834 | 155835 | 155836 | 155837 | 155873 | 155874 | 155875 | 155876 | 155877 | 155878 | 155879 | 155880 | 155881 | 155882 | 155883 | 155886 | 155934 | 155935 | 155936 | 155937 | 155938 | 155939 | 155940 | 155941 | 155942 | 155943 | 155944 | 155945 | 155946