Bugzilla – Attachment 53730 Details for
Bug 16864
Silence warnings in t/db_dependent/ILSDI_Services.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t
Bug-16864-Silence-warnings-in-tdbdependentILSDISer.patch (text/plain), 1.42 KB, created by
Marc Véron
on 2016-07-26 18:06:10 UTC
(
hide
)
Description:
Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2016-07-26 18:06:10 UTC
Size:
1.42 KB
patch
obsolete
>From dd1de9614e6228e6c36707110eb4f438db0a1148 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Wed, 6 Jul 2016 14:17:20 -0400 >Subject: [PATCH] Bug 16864: Silence warnings in > t/db_dependent/ILSDI_Services.t > >prove t/db_dependent/ILSDI_Services.t >generates noisy output as a result of the ambiguous context >of two $cgi->param() calls. > >By storing into scalar variables, and then using the scalar >variables, the code maintains readability and fixes the problem. > >TEST PLAN >--------- >1) prove t/db_dependent/ILSDI_Services.t > -- noisy. >2) apply patch >3) prove t/db_dependent/ILSDI_Services.t > -- not noisy >4) run koha qa test tools > >Signed-off-by: Marc <veron@veron.ch> >--- > C4/ILSDI/Services.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm >index 9f5a766..2820fef 100644 >--- a/C4/ILSDI/Services.pm >+++ b/C4/ILSDI/Services.pm >@@ -321,7 +321,9 @@ Parameters: > > sub AuthenticatePatron { > my ($cgi) = @_; >- my ($status, $cardnumber, $userid) = C4::Auth::checkpw( C4::Context->dbh, $cgi->param('username'), $cgi->param('password') ); >+ my $username = $cgi->param('username'); >+ my $password = $cgi->param('password'); >+ my ($status, $cardnumber, $userid) = C4::Auth::checkpw( C4::Context->dbh, $username, $password ); > if ( $status ) { > # Get the borrower > my $borrower = GetMember( cardnumber => $cardnumber ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16864
:
53151
|
53730
|
53881