Bugzilla – Attachment 53734 Details for
Bug 14642
Add logging of hold modifications
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14642: (QA followup) Make HoldsLog default to 0
Bug-14642-QA-followup-Make-HoldsLog-default-to-0.patch (text/plain), 3.30 KB, created by
Tomás Cohen Arazi (tcohen)
on 2016-07-26 19:06:27 UTC
(
hide
)
Description:
Bug 14642: (QA followup) Make HoldsLog default to 0
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2016-07-26 19:06:27 UTC
Size:
3.30 KB
patch
obsolete
>From af02c796c5793d5b3e1e3fc54d981a502d877c5e Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 26 Jul 2016 16:04:16 -0300 >Subject: [PATCH] Bug 14642: (QA followup) Make HoldsLog default to 0 > >After a couple comments regarding the default value I picked for the >new syspref, I've decided to set it 0, as libraries interested on the >fetarue will just enable it. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql | 4 ++-- > installer/data/mysql/sysprefs.sql | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql b/installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql >index aca2ee3..85a08eb 100644 >--- a/installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql >+++ b/installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql >@@ -1,11 +1,11 @@ > INSERT IGNORE INTO systempreferences ( variable, value, options, explanation, type ) VALUES >-('HoldsLog','1',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'); >+('HoldsLog','0',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'); > > -- $DBversion = "16.06.00.XXX"; > -- if ( CheckVersion($DBversion) ) { > -- $dbh->do(q{ > -- INSERT IGNORE INTO systempreferences ( variable, value, options, explanation, type ) VALUES >--- ('HoldsLog','1',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'); >+-- ('HoldsLog','0',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'); > -- }); > > -- print "Upgrade to $DBversion done (Bug 14642: Add logging of hold modifications)\n"; >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 3922b43..ffe31eb 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -168,7 +168,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('HighlightOwnItemsOnOPAC','0','','If on, and a patron is logged into the OPAC, items from his or her home library will be emphasized and shown first in search results and item details.','YesNo'), > ('HighlightOwnItemsOnOPACWhich','PatronBranch','PatronBranch|OpacURLBranch','Decides which branch\'s items to emphasize. If PatronBranch, emphasize the logged in user\'s library\'s items. If OpacURLBranch, highlight the items of the Apache var BRANCHCODE defined in Koha\'s Apache configuration file.','Choice'), > ('HoldFeeMode','not_always','always|not_always','Set the hold fee mode','Choice'), >-('HoldsLog','1',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'), >+('HoldsLog','0',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'), > ('HoldsQueueSkipClosed', '0', NULL, 'If enabled, any libraries that are closed when the holds queue is built will be ignored for the purpose of filling holds.', 'YesNo'), > ('HoldsToPullStartDate','2',NULL,'Set the default start date for the Holds to pull list to this many days ago','Integer'), > ('HomeOrHoldingBranch','holdingbranch','holdingbranch|homebranch','Used by Circulation to determine which branch of an item to check with independent branches on, and by search to determine which branch to choose for availability ','Choice'), >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14642
:
52824
|
52825
|
52848
|
52931
|
53070
|
53196
|
53466
|
53734
|
54177
|
54179
|
54180
|
54181
|
54182
|
54183