Bugzilla – Attachment 53798 Details for
Bug 15839
Move the reviews related code to Koha::Reviews
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15839: Koha::Reviews - Change default value for approved to 0
Bug-15839-KohaReviews---Change-default-value-for-a.patch (text/plain), 2.18 KB, created by
Marcel de Rooy
on 2016-07-29 09:44:28 UTC
(
hide
)
Description:
Bug 15839: Koha::Reviews - Change default value for approved to 0
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-07-29 09:44:28 UTC
Size:
2.18 KB
patch
obsolete
>From 34575023629ec0132736707f68e0e2174844ad6d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 16 Feb 2016 16:53:41 +0000 >Subject: [PATCH] Bug 15839: Koha::Reviews - Change default value for approved > to 0 >Content-Type: text/plain; charset=utf-8 > >The reviews.approved column had a default value set to NULL. >It does not make sense, the default value should be 0, this will avoid >to have to specify the approved value when creating a new review. > >Signed-off-by: Marc Veron <veron@veron.ch> >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > installer/data/mysql/atomicupdate/bug_review.sql | 1 + > installer/data/mysql/kohastructure.sql | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_review.sql > >diff --git a/installer/data/mysql/atomicupdate/bug_review.sql b/installer/data/mysql/atomicupdate/bug_review.sql >new file mode 100644 >index 0000000..076c3b5 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_review.sql >@@ -0,0 +1 @@ >+ALTER TABLE reviews CHANGE COLUMN approved approved tinyint(4) DEFAULT 0; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index ded442c..71b0da2 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -1932,7 +1932,7 @@ CREATE TABLE `reviews` ( -- patron opac comments > `borrowernumber` int(11) default NULL, -- foreign key from the borrowers table defining which patron left this comment > `biblionumber` int(11) default NULL, -- foreign key from the biblio table defining which bibliographic record this comment is for > `review` text, -- the body of the comment >- `approved` tinyint(4) default NULL, -- whether this comment has been approved by a librarian (1 for yes, 0 for no) >+ `approved` tinyint(4) default 0, -- whether this comment has been approved by a librarian (1 for yes, 0 for no) > `datereviewed` datetime default NULL, -- the date the comment was left > PRIMARY KEY (`reviewid`), > CONSTRAINT `reviews_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE, >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15839
:
48166
|
48167
|
48168
|
48169
|
48170
|
48171
|
48172
|
48173
|
48174
|
48175
|
48176
|
48280
|
48281
|
48282
|
48283
|
48284
|
48285
|
48286
|
48287
|
48288
|
48289
|
48290
|
51197
|
51198
|
51199
|
51200
|
51201
|
51202
|
51203
|
51204
|
51205
|
51206
|
51207
|
53794
|
53795
|
53796
|
53797
| 53798 |
53799
|
53800
|
53801
|
53802
|
53803
|
53804
|
53805
|
53806
|
53807