Attachment 53821 Details for Bug 16989 – [PASSED QA] Bug 16989 - Advanced search form does not display translated itemtype

[patch] [PASSED QA] Bug 16989 - Advanced search form does not display translated itemtype

PASSED-QA-Bug-16989---Advanced-search-form-does-no.patch (text/plain), 2.55 KB, created by Katrin Fischer on 2016-07-31 21:26:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-07-31 21:26:49 UTC

Size: 2.55 KB

patch

obsolete

>From 3024f3ad8adbf25d66708323e95caea900dc9a04 Mon Sep 17 00:00:00 2001
>From: Marc <veron@veron.ch>
>Date: Wed, 27 Jul 2016 21:19:16 +0200
>Subject: [PATCH] [PASSED QA] Bug 16989 - Advanced search form does not display
> translated itemtype
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>In Staff client, the advanced serach form does not display the
>translations of item types.
>
>(Note: It is not necessary to have translations installed to verify
>this bug.)
>
>Prerequisites:
>- Go to Home > Administration > Item types administration
>- Edit e.g. item type "BK" (Book)
>- Near "Description", click link "Translate into other languages
>- If you have other languaes installed, add translatons for those
>- If you have an Englis only installation, add a "translation" for
>  English, make sure that you can identify it while testing (I
>  used "BOOOOOOOOOOOOKS")
>
>Verify:
>- Go to Home âº Advanced search
>- Verify near "Limit to any of the following" that the description for
>  itemtype BK reads "Book" instead of "BOOOOOOOOOOOOKS"
>
>Test:
>- Apply patch
>- Verify that the item type description now reads ""BOOOOOOOOOOOOKS"
>- If you have a multi language installaton, verify that item types
>  you translated display as appropriate
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> catalogue/search.pl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/catalogue/search.pl b/catalogue/search.pl
>index dcbd21c..b2e3238 100755
>--- a/catalogue/search.pl
>+++ b/catalogue/search.pl
>@@ -806,8 +806,8 @@ sub prepare_adv_search_types {
>             my @itypesloop;
>             foreach my $thisitemtype (
>                 sort {
>-                    $itemtypes->{$a}->{'description'}
>-                      cmp $itemtypes->{$b}->{'description'}
>+                    $itemtypes->{$a}->{'translated_description'}
>+                      cmp $itemtypes->{$b}->{'translated_description'}
>                 } keys %$itemtypes
>               )
>             {
>@@ -815,7 +815,7 @@ sub prepare_adv_search_types {
>                     number      => $cnt++,
>                     ccl         => "$itype_or_itemtype,phr",
>                     code        => $thisitemtype,
>-                    description => $itemtypes->{$thisitemtype}->{'description'},
>+                    description => $itemtypes->{$thisitemtype}->{'translated_description'},
>                     imageurl    => getitemtypeimagelocation(
>                         'intranet', $itemtypes->{$thisitemtype}->{'imageurl'}
>                     ),
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 16989: 53756 | 53789 | 53821