Attachment 53822 Details for Bug 16995 – [PASSED QA] Bug 16995 - Remove event attributes from two include files

[patch] [PASSED QA] Bug 16995 - Remove event attributes from two include files

PASSED-QA-Bug-16995---Remove-event-attributes-from.patch (text/plain), 3.29 KB, created by Katrin Fischer on 2016-07-31 21:37:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-07-31 21:37:06 UTC

Size: 3.29 KB

patch

obsolete

>From 7078d8191323bfe461aa5d27a704aefbfb64a935 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 28 Jul 2016 14:33:16 -0400
>Subject: [PATCH] [PASSED QA] Bug 16995 - Remove event attributes from two
> include files
>
>This patch removes event attributes from two include files:
>cat-toolbar.inc and members-toolbar.inc.
>
>In cat-toolbar.inc an unused <form> tag with an "onsubmit" attribute has
>been removed.
>
>To test, apply the patch and:
>
>- View the detail page for any bibliographic record. All toolbar buttons
>  ("New," "Edit," "Save," etc.) should work as expected.
>- View the detail page for any patron. Click the "Add message" button in
>  the toolbar. Selecting a predefined note should correctly populate the
>  textarea with your selected message.
>
>Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc     | 3 ---
> koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc | 9 ++++++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>index 68aeefa..b809c4e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>@@ -127,8 +127,6 @@
> 
> <div id="toolbar" class="btn-toolbar">
> 
>-<form method="post" name="f" id="f" action="/cgi-bin/koha/cataloguing/addbiblio.pl" onsubmit="return Check();">
>-
> [% IF ( CAN_user_editcatalogue_edit_catalogue || CAN_user_editcatalogue_edit_items ||
> CAN_user_serials_create_subscription ) %]
>     <div class="btn-group">
>@@ -263,7 +261,6 @@ CAN_user_serials_create_subscription ) %]
>     [% END %]
> [% END %]
> 
>-</form>
> </div>
> 
>     
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
>index 7f7fe5c..242608e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
>@@ -69,7 +69,10 @@ $(document).ready(function(){
>     $("#searchtohold").click(function(){
>         searchToHold();
>         return false;
>-    })
>+    });
>+    $("#select_patron_messages").on("change",function(){
>+        $("#borrower_message").val( $(this).val() );
>+    });
> });
> function confirm_deletion() {
>     var is_confirmed = window.confirm(_("Are you sure you want to delete this patron? This cannot be undone."));
>@@ -234,8 +237,8 @@ function searchToHold(){
>                 [% bor_notes = AuthorisedValues.Get( 'BOR_NOTES' ) %]
>                 [% IF bor_notes %]
>                     <li>
>-                        <label for="type">Predefined notes: </label>
>-                        <select name="type" id="type" onchange="this.form.borrower_message.value=this.options[this.selectedIndex].value;">
>+                        <label for="select_patron_messages">Predefined notes: </label>
>+                        <select name="type" id="select_patron_messages">
>                             <option value="">Select note</option>
>                             [% FOREACH bor_note IN bor_notes %]
>                                 <option value="[% bor_note.lib %]">[% bor_note.lib %]</option>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 16995: 53790 | 53812 | 53822