Bugzilla – Attachment 53873 Details for
Bug 16622
some tests triggered by prove t fail for unset KOHA_CONF
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16622: some tests triggered by prove t fail for unset KOHA_CONF
Bug-16622-some-tests-triggered-by-prove-t-fail-for.patch (text/plain), 2.10 KB, created by
Jonathan Druart
on 2016-08-02 08:33:36 UTC
(
hide
)
Description:
Bug 16622: some tests triggered by prove t fail for unset KOHA_CONF
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-08-02 08:33:36 UTC
Size:
2.10 KB
patch
obsolete
>From c32f4880ec724f315185d37ec7e7183c7c4f4bcf Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Tue, 31 May 2016 12:01:46 -0400 >Subject: [PATCH] Bug 16622: some tests triggered by prove t fail for unset > KOHA_CONF >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >TEST PLAN >--------- >1) unset KOHA_CONF >2) prove t > -- 00-load.t dies miserably >3) prove t/Creators.t > -- fails >4) apply patch >5) prove t > -- noisy, but all tests successful >6) prove -v t/Creators.t > -- 2 skipped tests >7) run koha qa test tools > >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Auth_with_cas.pm | 1 - > t/Creators.t | 19 ++++++++++++------- > 2 files changed, 12 insertions(+), 8 deletions(-) > >diff --git a/C4/Auth_with_cas.pm b/C4/Auth_with_cas.pm >index c9174da..d8ea7cf 100644 >--- a/C4/Auth_with_cas.pm >+++ b/C4/Auth_with_cas.pm >@@ -36,7 +36,6 @@ BEGIN { > @ISA = qw(Exporter); > @EXPORT = qw(check_api_auth_cas checkpw_cas login_cas logout_cas login_cas_url); > } >-my $context = C4::Context->new() or die 'C4::Context->new failed'; > my $defaultcasserver; > my $casservers; > my $yamlauthfile = C4::Context->config('intranetdir') . "/C4/Auth_cas_servers.yaml"; >diff --git a/t/Creators.t b/t/Creators.t >index cdeb630..6e825d6 100755 >--- a/t/Creators.t >+++ b/t/Creators.t >@@ -68,12 +68,17 @@ foreach my $font ( @$font_types ) { > $y += $pdf_creator->FontSize() * 1.2; > } > >-my ($fh, $filename) = tempfile(); >-open( $fh, '>', $filename ); >-select $fh; >+SKIP: { >+ skip "Skipping because without proper fonts these two tests fail", >+ 2 if ! $ENV{KOHA_CONF}; > >-ok($pdf_creator->End(), "testing End() works"); >+ my ($fh, $filename) = tempfile(); >+ open( $fh, '>', $filename ); >+ select $fh; > >-close($fh); >-ok( -s $filename , "test file $filename created OK" ); >-unlink $filename unless $ENV{KEEP_PDF}; >+ ok($pdf_creator->End(), "testing End() works"); >+ >+ close($fh); >+ ok( -s $filename , "test file $filename created OK" ); >+ unlink $filename unless $ENV{KEEP_PDF}; >+} >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16622
:
53279
|
53731
| 53873