Bugzilla – Attachment 53874 Details for
Bug 16955
Internal Server Error while populating new framework
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16955: Do not clear from cache when adding a new framework
Bug-16955-Do-not-clear-from-cache-when-adding-a-ne.patch (text/plain), 1.65 KB, created by
Jonathan Druart
on 2016-08-02 08:46:54 UTC
(
hide
)
Description:
Bug 16955: Do not clear from cache when adding a new framework
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-08-02 08:46:54 UTC
Size:
1.65 KB
patch
obsolete
>From 01816a4c79e1d9cbba9d60cfee83cb8524b93bec Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 2 Aug 2016 09:43:01 +0100 >Subject: [PATCH] Bug 16955: Do not clear from cache when adding a new > framework > >There are several issues with these lines: >1/ $cache is not defined correctly and it not visible inside >duplicate_framework >2/ $frameworkcode is a wrong c/p, it should be $newframeworkcode >3/ these calls are not needed. As we are creating a new framework, the cache >should be empty... > >This patch will simply remove these calls > >Test plan: >Duplicate a framework and confirm that you do not get any error in your >logs. >--- > admin/marctagstructure.pl | 4 ---- > 1 file changed, 4 deletions(-) > >diff --git a/admin/marctagstructure.pl b/admin/marctagstructure.pl >index 27d9592..0f27ac0 100755 >--- a/admin/marctagstructure.pl >+++ b/admin/marctagstructure.pl >@@ -357,9 +357,5 @@ sub duplicate_framework { > while ( my ($frameworkcode, $tagfield, $tagsubfield, $liblibrarian, $libopac, $repeatable, $mandatory, $kohafield, $tab, $authorised_value, $thesaurus_category, $value_builder, $seealso,$hidden) = $sth->fetchrow) { > $sth_insert->execute($newframeworkcode, $tagfield, $tagsubfield, $liblibrarian, $libopac, $repeatable, $mandatory, $kohafield, $tab, $authorised_value, $thesaurus_category, $value_builder, $seealso, $hidden); > } >- $cache->clear_from_cache("MarcStructure-0-$newframeworkcode"); >- $cache->clear_from_cache("MarcStructure-1-$newframeworkcode"); >- $cache->clear_from_cache("default_value_for_mod_marc-$frameworkcode"); >- $cache->clear_from_cache("MarcSubfieldStructure-$frameworkcode"); > } > >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16955
:
53612
|
53815
|
53874
|
54086
|
54387