Bugzilla – Attachment 53889 Details for
Bug 13895
Add routes for checkouts retrieval and renewal
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13895: Fixed QA demands
Bug-13895-Fixed-QA-demands.patch (text/plain), 1.52 KB, created by
Frédéric Demians
on 2016-08-02 11:12:40 UTC
(
hide
)
Description:
Bug 13895: Fixed QA demands
Filename:
MIME Type:
Creator:
Frédéric Demians
Created:
2016-08-02 11:12:40 UTC
Size:
1.52 KB
patch
obsolete
>From e41515bafbdc28086dfc06ca57da2987b27db9f1 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Ji=C5=99=C3=AD=20Kozlovsk=C3=BD?= <mail@jkozlovsky.cz> >Date: Sun, 31 Jul 2016 11:19:09 +0200 >Subject: [PATCH] Bug 13895: Fixed QA demands >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Frédéric Demians <f.demians@tamil.fr> > Fix QA, and fix tests failing >--- > Koha/REST/V1/Checkout.pm | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > >diff --git a/Koha/REST/V1/Checkout.pm b/Koha/REST/V1/Checkout.pm >index 5dd8128..530e491 100644 >--- a/Koha/REST/V1/Checkout.pm >+++ b/Koha/REST/V1/Checkout.pm >@@ -72,12 +72,13 @@ sub renew { > > if (!$checkout) { > return $c->$cb({ >- error => "Checkout doesn't exists" >+ error => "Checkout doesn't exist" > }, 404); > } > >- $checkout = $checkout->unblessed; >- my ($borrowernumber, $itemnumber) = @$checkout{qw(borrowernumber itemnumber)}; >+ my $borrowernumber = $checkout->borrowernumber; >+ my $itemnumber = $checkout->itemnumber; >+ > my ($can_renew, $error) = C4::Circulation::CanBookBeRenewed( > $borrowernumber, $itemnumber); > >@@ -85,7 +86,7 @@ sub renew { > return $c->$cb({error => "Renewal not authorized ($error)"}, 403); > } > >- AddRenewal($borrowernumber, $itemnumber, $checkout->{branchcode}); >+ AddRenewal($borrowernumber, $itemnumber, $checkout->branchcode); > $checkout = Koha::Issues->find($checkout_id); > > return $c->$cb($checkout->unblessed, 200); >-- >2.9.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13895
:
37146
|
40104
|
40143
|
40588
|
41163
|
41548
|
45817
|
50021
|
51303
|
53816
|
53817
|
53878
|
53889
|
53890
|
53891
|
53901
|
53924
|
54196
|
54685
|
54951
|
56167
|
56506
|
58387
|
69123
|
84765
|
85458
|
85459
|
85460
|
85461
|
85462
|
85463
|
85464
|
85676
|
86120
|
86576
|
86579
|
86580
|
87105
|
87106
|
87107
|
87108
|
87109
|
87110
|
87111
|
87112
|
87113
|
87114
|
87115
|
87200