Bugzilla – Attachment 5404 Details for
Bug 5725
Batch modifications for Biblios
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
owen fix signed-off
0001-Additional-fixes-for-Bug-5725-Batch-modifications-fo.patch (text/plain), 9.50 KB, created by
Paul Poulain
on 2011-09-12 13:37:26 UTC
(
hide
)
Description:
owen fix signed-off
Filename:
MIME Type:
Creator:
Paul Poulain
Created:
2011-09-12 13:37:26 UTC
Size:
9.50 KB
patch
obsolete
>From 306e4f38bbd3a711b0960d07f96e4b0bd38ecac8 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 8 Aug 2011 15:53:53 -0400 >Subject: [PATCH] Additional fixes for Bug 5725 - Batch modifications for Biblios > >- Correcting page title >- Adding breadcrums >- Adding sidebar menu (matching other batch mod pages) >- Showing "loading" graphic during AJAX operations >- Adding empty option to list of MARC tags so that onchange event > will fire when the user is choosing 000 >- Other structural markup changes > >Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> >--- > .../prog/en/modules/tools/batchedit.tt | 49 +++++++++++++------ > koha-tmpl/intranet-tmpl/prog/img/loading-small.gif | Bin 0 -> 1652 bytes > 2 files changed, 33 insertions(+), 16 deletions(-) > create mode 100644 koha-tmpl/intranet-tmpl/prog/img/loading-small.gif > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchedit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchedit.tt >index 8e0d80e..31c84d1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchedit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchedit.tt >@@ -1,5 +1,5 @@ > [% INCLUDE 'doc-head-open.inc' %] >-<title>Koha › Tools › Batch Deletion of Items</title> >+<title>Koha › Tools › Batch record of modification</title> > [% INCLUDE 'doc-head-close.inc' %] > > [% UNLESS ( modsuccess ) %] >@@ -10,10 +10,12 @@ > > function fieldChanged(){ > var field = $('#fieldchoice').val(); >+ $("#loading").html(" <img src=\"/intranet-tmpl/prog/img/loading-small.gif\" alt=\"\" />"); > $.ajax({ > url: CGIBIN + 'tools/batchedit.pl?field=' + field, > dataType: 'json', > success: function(data){ >+ $("#loading").html(""); > $("#subfieldchoice option").remove(); > > var subfield = $('#subfieldchoice'); >@@ -60,7 +62,7 @@ > $("#condvaltd").html('<input type="text" name="condvalchoice" id="condvalchoice" />'); > $("#repvaltd").html('<input type="text" name="repvalchoice" id="repvalchoice" />'); > } >- $('<input type="checkbox" id="nocond" name="nocond" value="nocond" onClick="$(\'#condvalchoice\').attr(\'disabled\', ! $(\'#condvalchoice\').attr(\'disabled\') ) ">All</input>').appendTo("#condvaltd"); >+ $('<label> <input type="checkbox" id="nocond" name="nocond" value="nocond" onClick="$(\'#condvalchoice\').attr(\'disabled\', ! $(\'#condvalchoice\').attr(\'disabled\') ) " /> All</label>').appendTo("#condvaltd"); > } > }); > >@@ -116,24 +118,40 @@ > <body> > [% INCLUDE 'header.inc' %] > [% INCLUDE 'cat-search.inc' %] >+ >+<div id="breadcrumbs"> >+ <a href="/cgi-bin/koha/mainpage.pl">Home</a> › >+ <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> › >+ <a href="/cgi-bin/koha/tools/batchedit.pl">Batch record modification</a> >+</div> >+ > <div id="doc3" class="yui-t2"> > <div id="bd"> > <div id="yui-main"> > <div class="yui-b"> > >-<form method="post" enctype="multipart/form-data"> >+<form method="post" action="/cgi-bin/koha/tools/batchedit.pl" enctype="multipart/form-data"> > [% IF ( moddone ) %] > <div class="dialog message">All operations processed</div> > [% END %] > > [% UNLESS ( bib_list ) %] >- <h2>Batch records modification</h2> >+ <h2>Batch record modification</h2> >+ <div class="yui-g"> >+ <div class="yui-u first"> > <fieldset class="rows"> > <legend>Use a file of biblionumbers</legend> > <ol> > <li><label for="uploadfile">File: </label> <input type="file" id="uploadfile" name="uploadfile" /></li> > </ol> > </fieldset> >+ </div> >+ <div class="yui-u"> >+ <div class="container"> >+ <p><b>Reminder</b>: You can also add records to your cart and reach this page from the cart.</p> >+ </div> >+ </div> >+ </div> > <fieldset class="rows"> > <legend>Or enter records one by one</legend> > <ol> >@@ -142,7 +160,7 @@ > <textarea rows="10" cols="30" id="recordslist" name="recordslist"></textarea> > </li> > </ol> >- <p><b>Reminder</b>: you can also add biblios to your cart and reach this page from the cart</p> >+ > </fieldset> > [% ELSE %] > <h2>List of records:</h2> >@@ -155,7 +173,7 @@ > [% FOREACH biblioinfo IN biblioinfos %] > <tr> > <td>[% biblioinfo.biblionumber %]</td> >- <td>[% biblioinfo.title %]</td> >+ <td>[% biblionumber = biblioinfo.biblionumber %] [% INCLUDE 'biblio-default-view.inc' %][% IF ( biblioinfo.title ) %][% biblioinfo.title |html %][% ELSE %]No title[% END %]</a></td> > <td>[% biblioinfo.author %]</td> > [% IF ( moddone ) %] > [% IF ( biblioinfo.OK ) %] >@@ -180,7 +198,6 @@ > [% IF ( bib_list ) %] > <fieldset class="rows"> > <h2>Modification rules:</h2> >- <input type="submit" value="Submit" /> > <input type="hidden" name="op" value="do" /> > <input type="hidden" name="bib_list" value="[% bib_list %]" /> > <table id="rulestable"> >@@ -192,6 +209,7 @@ > <tr> > <td> > <select name="fieldchoice" id="fieldchoice" onchange="fieldChanged();"> >+ <option value=""></option> > [% FOREACH marcfield IN marcfields %] > <option value="[% marcfield.tag %]">[% marcfield.tag %]</option> > [% END %] >@@ -199,8 +217,7 @@ > </td> > <td> > <select name="subfieldchoice" id="subfieldchoice" onchange="subfieldChanged();"> >- >- </select> >+ </select><span id="loading"></span> > </td> > <td> > <select name="actionchoice" id="actionchoice"> >@@ -212,7 +229,7 @@ > </td> > <td id="condvaltd"> > <input type="text" name="condvalchoice" id="condvalchoice" /> >- <input type="checkbox" id="nocond" name="nocond" value="nocond" onClick="$('#condvalchoice').attr('disabled', ! $('#condvalchoice').attr('disabled') ) ">All</input> >+ <label> <input type="checkbox" id="nocond" name="nocond" value="nocond" onclick="$('#condvalchoice').attr('disabled', ! $('#condvalchoice').attr('disabled') ) " /> All </label> > </td> > <td id="repvaltd"> > <input type="text" name="repvalchoice" id="repvalchoice" /> >@@ -223,18 +240,18 @@ > > </table> > <input type="hidden" name="bib_list" value="[% bib_list %]" /> >- <input type="submit" value="Submit" /> (don't forget to click "Add" button on the right of the previous form before submitting) >+ <fieldset class="action"><input type="submit" value="Submit" /> (don't forget to click "Add" button on the right of the previous form before submitting)</fieldset> > </fieldset> > </form> > [% ELSE %] >- <input type="submit" value="Submit" /> >- </fieldset> >+ <fieldset class="action"><input type="submit" value="Submit" /></fieldset> > </form> > [% END %] > [% END %] > </div> > </div> >+ <div class="yui-b"> >+ [% INCLUDE 'tools-menu.inc' %] >+ </div> > </div> >-</div> >-</body> >-</html> >+[% INCLUDE 'intranet-bottom.inc' %] >diff --git a/koha-tmpl/intranet-tmpl/prog/img/loading-small.gif b/koha-tmpl/intranet-tmpl/prog/img/loading-small.gif >new file mode 100644 >index 0000000000000000000000000000000000000000..79ea508aa675a47ce0a4a488ed91b7467ab8a4b0 >GIT binary patch >literal 1652 >zcmZ9MYfMvT9LA3nI&Ot>v4dKm<&@rgETz{YTj+%zTBNdCCMX@3*;+tUgffv4Md?Nj >zAQe#rLB~x%iNF{N8w<F=L}cR<oGj@wh9EfNLJUjz!gkPofW2Se<o!MW=Xw4wqE<<y >zX?Oq+%)$T$gYoqA^!N8Ckw_p2(r7d$lgZ_B`Fy@eB#MlTl*wc&l}e-0Xti3MPM467 >zkd%~UFc{L((o7~(W@ct~c6Lrqj>TdrC@3f@Dk?56wpy(=o2{&@%x<?=S6A28);2UW >zG&VN2w6wIhw|91Sc6D|2_V)Jo_YV#Z4i68HjEszpjZI8UOioVD&d$!w%{d&7`T6<9 >z#l_|2<<-^IwY9bN_4SR7jm^zXVCSLy<Dre#A5_TVqxldIvkSeYYzE0K8OQU;pJn8k >z$%tA-jysv3VI(8Qw9{k(!~-ZB&Mqzh3~;ud+VTOw-ioR})fOu&jR~4?nz1?$B(tvF >zqfiHaj(SO)D($WHGR9k6Asw6bEIX8S^TivvT`M7Wl+27tyaOasg_H|2QWRXOnx~gD >zsnoCtwS>cFmj#EA`D!tfPG>0ud)53)@)`=QM9Bi#Vmk=c@Fe1hoban9;VD8eoNEK) >z#FcU>odI)b(^OGHSPDA~meAs^%OU1ZO4&}$IKTtdY}nH5VJKA)RjprB^ZLKYG*_AP >z0<2!nsVioY!@cK;ApQJ8{=%aS<^6>A)TSbYh==G;9Xe3KW5&R|aEQfV<j0^=>2!wB >zdQQJThMzBmsPxZKjsGL!0auimutj7Spf2H*GZxxFowEA7Y$fa+mX+v}C3dhe9to+~ >z3W)C4sOe5-gyq%;h!Ux(Gjkt<45?HhAp))pCF%r;tbo{TPEm}I!eVo`kuYc;IKcfK >zDgI6<?y^W9hy1a8s_qy3A^D0X$nlsG^hCw0LjJ~oV1$#PZyJa7ggxWkL*?=Pp!U-< >zZFvF%LQ%;%B1A4A1(RtSTZTK<#Y<$i(a*`Zkz7!c2jGR0j8XNkTYQODk)xye2V3gs >z)r#op7CwK$JW8Arv@Jb-)iaiSt8P4Wc(Fn{iCKV&acSRn_jT(d&qny*JPBv%9Mwq# >z=M1VjXrST#0<sfciss1>fYCe(oW`LYq^h@*U4dPwm)<B@KXe7UerctGR-dKZ_ev|$ >zWj${m(>{29?Bc$q{ehKJ{k8DrzW6V})6;xH?2oqe`pZ>Lrq-rvvJiB2l>{>Z1{_X@ >z)xOR`tz3YyAxuPkY}<%fzzMZ-YsBQJpz-G1a`V88GE0yB@IZ2>xoPZefn#a8om1+i >z^}gH2`xDC0ucrGZUn(^BlQaHWnwMQMg){tw3?Dx!oq*@Kgu)SKUoSWS%QNDu1fDEo >zV1U~2$u=Mca6!|1+sq*!)*be%(_Bg%QW#j?Rbw|65_0a%c33--EPc9_<{owD-Wt2} >za1wGuClofFH}kKJKKu1lDI3GsgNMB7uuv<)2EYLxaELempnEmJE!CfM;KY^P(Mr`e >zB7i#iu9>=_*%jr5m5RqlGTY<>s+i_7!l2RVy=47$V&@4YnyeqM%;=iLsaT5-`G&jk >z?rG^as$UcCib!yXA50_akMP{i2KyEUagQK}Vd@^_WXui>_P<&limI>N?Mt+DB`&Si >zJgktDviypbiSZ7uv8=v_U;8XK@%P&u_6qs(WE8Cq*ZOEAkIPxL!$s*J50Mbwhr@zk >z7FDDY_#dE>4%05Ej={`OxfI^P!k`x7(A17b8Dd)t%T4#H%A2cPl@Hv<RaNzQLT^gW >z_{#Uc?Hzx^{qw`!9$3?+DF7F9H@l*9878^O-Rgv1p&~k4ERJBo5CroBIV`k`MoCBr >z%%Z^@qkt3+v%?BZk`#!UvID&3=2kC1+S>9$oY8e5^9;zz;{+YYy4=(bAdMv#kETy+ >zc3l|vIdqHCzOZrL+Msd4fbJQi6sTpT#!3lfh|w*GP8FaFpg{k!c!e-b0JCMlzJCFD >Ci6N~3 > >literal 0 >HcmV?d00001 > >-- >1.7.4.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5725
:
3105
|
3108
|
3191
|
3193
|
3234
|
3356
|
4734
|
4735
|
4736
|
4863
|
4864
|
4897
|
4898
|
4899
|
5404
|
5405
|
5684
|
5685
|
5697
|
5959
|
5960
|
5980
|
5981
|
5982
|
10610
|
10611
|
10612
|
11731
|
11732
|
11733