Bugzilla – Attachment 54047 Details for
Bug 17055
Add classes to different note types to allow for styling on checkins page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 17055 - Add classes to different note types to allow for styling on checkins page
SIGNED-OFF-Bug-17055---Add-classes-to-different-no.patch (text/plain), 2.22 KB, created by
Owen Leonard
on 2016-08-05 14:10:59 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 17055 - Add classes to different note types to allow for styling on checkins page
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2016-08-05 14:10:59 UTC
Size:
2.22 KB
patch
obsolete
>From 649bf0d7068b128f167c0e57e1817ec03454f525 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 5 Aug 2016 13:56:52 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 17055 - Add classes to different note types > to allow for styling on checkins page >Content-Type: text/plain; charset="utf-8" > >Returned items may have 3 kinds of notes, patron, item public, and item >non-public. However, the html markup for them does not allow us to >distinguish which type we are seeing. It would be good to add classes >for each of these note types. > >Test Plan: >1) Check out an item to a patron >2) Add a patron note, a public item note, and a non-public item note > to the patron and item you used >3) Check in the item and instead the html, note the each note span > now has a class to distinguish which type of note is being displayed. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index b656973..f55c997 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -660,9 +660,9 @@ $(document).ready(function () { > </a> > [% ELSE %]Not checked out[% END %]</td> > <td class="ci-note"> >- [% IF ( riloo.bornote ) %]<p><span class="circ-hlt">[% riloo.bornote %]</p></span>[% END %] >- [% IF ( riloo.itemnote ) %]<p><span class="circ-hlt">[% riloo.itemnote %]</p></span>[% END %] >- [% IF ( riloo.itemnotes_nonpublic ) %]<p><span class="circ-hlt">[% riloo.itemnotes_nonpublic %]</p></span>[% END %] >+ [% IF ( riloo.bornote ) %]<p><span class="circ-hlt patron-note">[% riloo.bornote %]</p></span>[% END %] >+ [% IF ( riloo.itemnote ) %]<p><span class="circ-hlt item-note-public">[% riloo.itemnote %]</p></span>[% END %] >+ [% IF ( riloo.itemnotes_nonpublic ) %]<p><span class="circ-hlt item-note-nonpublic">[% riloo.itemnotes_nonpublic %]</p></span>[% END %] > </td> > </tr> > [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17055
:
54046
|
54047
|
54108