Attachment 54108 Details for Bug 17055 – [PASSED QA] Bug 17055 - Add classes to different note types to allow for styling on checkins page

[patch] [PASSED QA] Bug 17055 - Add classes to different note types to allow for styling on checkins page

PASSED-QA-Bug-17055---Add-classes-to-different-not.patch (text/plain), 2.24 KB, created by Katrin Fischer on 2016-08-07 09:42:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-08-07 09:42:55 UTC

Size: 2.24 KB

patch

obsolete

>From 708ed77509a65146304d3c818c260a16a69c4685 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 5 Aug 2016 13:56:52 +0000
>Subject: [PATCH] [PASSED QA] Bug 17055 - Add classes to different note types
> to allow for styling on checkins page
>
>Returned items may have 3 kinds of notes, patron, item public, and item
>non-public. However, the html markup for them does not allow us to
>distinguish which type we are seeing. It would be good to add classes
>for each of these note types.
>
>Test Plan:
>1) Check out an item to a patron
>2) Add a patron note, a public item note, and a non-public item note
> to the patron and item you used
>3) Check in the item and instead the html, note the each note span
> now has a class to distinguish which type of note is being displayed.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index b656973..f55c997 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -660,9 +660,9 @@ $(document).ready(function () {
> </a>
> [% ELSE %]Not checked out[% END %]</td>
> <td class="ci-note">
>- [% IF ( riloo.bornote ) %][% riloo.bornote %][% END %]
>- [% IF ( riloo.itemnote ) %][% riloo.itemnote %][% END %]
>- [% IF ( riloo.itemnotes_nonpublic ) %][% riloo.itemnotes_nonpublic %][% END %]
>+ [% IF ( riloo.bornote ) %][% riloo.bornote %][% END %]
>+ [% IF ( riloo.itemnote ) %][% riloo.itemnote %][% END %]
>+ [% IF ( riloo.itemnotes_nonpublic ) %][% riloo.itemnotes_nonpublic %][% END %]
> </td>
> </tr>
> [% END %]
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 17055: 54046 | 54047 | 54108