Attachment 5415 Details for Bug 6620 – no regression after applying patch

[patch] no regression after applying patch

0001-Bug-6620-Ensure-autoflush-is-set-on-output-filehandl.patch (text/plain), 1.27 KB, created by Ulrich Kleiber on 2011-09-13 14:03:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ulrich Kleiber

Created: 2011-09-13 14:03:34 UTC

Size: 1.27 KB

patch

obsolete

>From b8e5055cc072b152e491389395e34fc6b13ffcb5 Mon Sep 17 00:00:00 2001
>From: Colin Campbell <colin.campbell@ptfs-europe.com>
>Date: Thu, 21 Jul 2011 12:16:22 +0100
>Subject: [PATCH] Bug 6620 Ensure autoflush is set on output filehandles
>
>stdout is by default buffered and a flush is only guaranteed on CR
>Sip responses are not CR terminated so we need to ensure autoflush
>is switched on  so that the filehandle is flushed after a print
>Otherwise this can manifest as self checks running slow or
>failing due to timeout (although in the log we see the response)
>
>Signed-off-by: Ulrich Kleiber <ulrich.kleiber@bsz-bw.de>
>---
> C4/SIP/Sip.pm |    5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
>diff --git a/C4/SIP/Sip.pm b/C4/SIP/Sip.pm
>index 8a0f067..337cc0e 100644
>--- a/C4/SIP/Sip.pm
>+++ b/C4/SIP/Sip.pm
>@@ -12,6 +12,7 @@ use Exporter;
> use Sys::Syslog qw(syslog);
> use POSIX qw(strftime);
> use Socket qw(:crlf);
>+use IO::Handle;
> 
> use Sip::Constants qw(SIP_DATETIME);
> use Sip::Checksum qw(checksum);
>@@ -230,9 +231,11 @@ sub write_msg {
> 
> 
>     if ($file) {
>+        $file->autoflush(1);
>         print $file "$msg\r";
>     } else {
>-        print "$msg\r";
>+        STDOUT->autoflush(1);
>+        print $msg, "\r";
>         syslog("LOG_INFO", "OUTPUT MSG: '$msg'");
>     }
> 
>-- 
>1.7.0.4
>

Actions: View | Diff | Splinter Review

Attachments on bug 6620: 4698 | 5415