Bugzilla – Attachment 54164 Details for
Bug 17080
Koha::Object->new should handle default values for NOT NULL columns
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17080: borrowers table - use default values defined in the DBIx::Class schema
Bug-17080-borrowers-table---use-default-values-def.patch (text/plain), 1.27 KB, created by
Jonathan Druart
on 2016-08-08 13:59:39 UTC
(
hide
)
Description:
Bug 17080: borrowers table - use default values defined in the DBIx::Class schema
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-08-08 13:59:39 UTC
Size:
1.27 KB
patch
obsolete
>From abc6f9e880f9b7e30618b1790e5f8d458a71daee Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 8 Aug 2016 14:14:03 +0100 >Subject: [PATCH] Bug 17080: borrowers table - use default values defined in > the DBIx::Class schema > >This patch basically just revert bug 16960 - Fix error on validating the >registration > >This job is now done by the Koha::Object constructor, no need to clean >the hash before sending it to AddMember. > >Test plan: >Make sure there is no regression on bug 16960 (validate a self registration). >--- > opac/opac-registration-verify.pl | 5 ----- > 1 file changed, 5 deletions(-) > >diff --git a/opac/opac-registration-verify.pl b/opac/opac-registration-verify.pl >index 20057b0..1098af0 100755 >--- a/opac/opac-registration-verify.pl >+++ b/opac/opac-registration-verify.pl >@@ -51,11 +51,6 @@ if ( $m ) { > OpacPasswordChange => C4::Context->preference('OpacPasswordChange') ); > > my $borrower = $m->unblessed(); >- # Avoid "Column 'column' cannot be null" errors >- # FIXME should be done at the Koha::Object level >- for my $key ( keys %$borrower ) { >- delete $borrower->{$key} if not defined $borrower->{$key} >- } > > my $password; > ( $borrowernumber, $password ) = AddMember_Opac(%$borrower); >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17080
:
54162
|
54163
|
54164
|
54165
|
54166
|
54465
|
54466
|
54467
|
54468
|
54469
|
56464
|
56465
|
56466
|
56467
|
56468
|
56728