Bugzilla – Attachment 54173 Details for
Bug 17081
Incorrect comparison operator used in edifactmsgs.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch
0001-Bug-17081-Use-correct-comparison-operator.patch (text/plain), 861 bytes, created by
Colin Campbell
on 2016-08-08 15:17:32 UTC
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2016-08-08 15:17:32 UTC
Size:
861 bytes
patch
obsolete
>From 952f2897a03edab41dd7fdb3b8650a3c87a4eef8 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Mon, 8 Aug 2016 16:13:37 +0100 >Subject: [PATCH] Bug 17081 Use correct comparison operator > >Use eq not == to compare strings >--- > acqui/edifactmsgs.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/acqui/edifactmsgs.pl b/acqui/edifactmsgs.pl >index 2a9a7af..608eaff 100755 >--- a/acqui/edifactmsgs.pl >+++ b/acqui/edifactmsgs.pl >@@ -39,7 +39,7 @@ my ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user( > > my $schema = Koha::Database->new()->schema(); > my $cmd = $q->param('op'); >-if ( $cmd && $cmd == 'delete' ) { >+if ( $cmd && $cmd eq 'delete' ) { > my $id = $q->param('message_id'); > my $msg = $schema->resultset('EdifactMessage')->find($id); > $msg->deleted(1); >-- >2.7.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17081
:
54173
|
54229
|
54248