Bugzilla – Attachment 54229 Details for
Bug 17081
Incorrect comparison operator used in edifactmsgs.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 17081 Incorrect comparison operator used in edifactmsgs.pl
SIGNED-OFF-Bug-17081-Incorrect-comparison-operator.patch (text/plain), 1.30 KB, created by
Owen Leonard
on 2016-08-09 16:32:18 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 17081 Incorrect comparison operator used in edifactmsgs.pl
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2016-08-09 16:32:18 UTC
Size:
1.30 KB
patch
obsolete
>From 471536425a7e20ab3df64ecd6d000630a33bf56a Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Mon, 8 Aug 2016 16:13:37 +0100 >Subject: [PATCH] [SIGNED-OFF] Bug 17081 Incorrect comparison operator used in > edifactmsgs.pl >Content-Type: text/plain; charset="utf-8" > >Numeric comparison operator is used where string comparison required, >resulting in the following warning in the log: 'Argument "delete" isn't >numeric in numeric eq (==).' > >This patch corrects it to use 'eq' not '==' to compare strings. > >To test, apply the patch and go to Acquisitions -> EDIFACT messages. > >Delete an EDIFACT message. There should be no error in the error log. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > acqui/edifactmsgs.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/acqui/edifactmsgs.pl b/acqui/edifactmsgs.pl >index 2a9a7af..608eaff 100755 >--- a/acqui/edifactmsgs.pl >+++ b/acqui/edifactmsgs.pl >@@ -39,7 +39,7 @@ my ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user( > > my $schema = Koha::Database->new()->schema(); > my $cmd = $q->param('op'); >-if ( $cmd && $cmd == 'delete' ) { >+if ( $cmd && $cmd eq 'delete' ) { > my $id = $q->param('message_id'); > my $msg = $schema->resultset('EdifactMessage')->find($id); > $msg->deleted(1); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17081
:
54173
|
54229
|
54248