Attachment 5426 Details for Bug 6458 – Revised fix for addbiblio.tt

[patch] Revised fix for addbiblio.tt

0001-Fix-for-Bug-6458-incorrect-parsing-addbiblio.patch (text/plain), 2.51 KB, created by Owen Leonard on 2011-09-14 13:23:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2011-09-14 13:23:57 UTC

Size: 2.51 KB

patch

obsolete

>From d3c7896ba707760b618bb7552156b4558a8df4ec Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 1 Sep 2011 11:14:50 -0400
>Subject: [PATCH] Fix for Bug 6458 - incorrect parsing result in translation processing
>Content-Type: text/plain; charset="utf-8"
>
>Fixing improperly nested template logic inside HTML tags in MARC
>editor. Modifying script to stop tag attribute markup from being
>passed to the template directly in favor of using template logic.
>---
> cataloguing/addbiblio.pl                           |    2 +-
> .../prog/en/modules/cataloguing/addbiblio.tt       |    8 ++++++--
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
>diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
>index 637d82d..21601e9 100755
>--- a/cataloguing/addbiblio.pl
>+++ b/cataloguing/addbiblio.pl
>@@ -874,7 +874,7 @@ foreach my $thisframeworkcode ( keys %$frameworks ) {
> 		frameworktext => $frameworks->{$thisframeworkcode}->{'frameworktext'},
> 	);
> 	if ($frameworkcode eq $thisframeworkcode){
>-		$row{'selected'}="selected=\"selected\"";
>+		$row{'selected'} = 1;
> 		}
> 	push @frameworkcodeloop, \%row;
> } 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>index 09bf2d6..baa84c7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>@@ -778,8 +778,12 @@ function unHideSubfield(index,labelindex) { // FIXME :: is it used ?
> 			<li id="changeframework"><label for="Frameworks">Change framework: </label>
> 			<select name="Frameworks" id="Frameworks" onchange="Changefwk(this);">
> 			                <option value="Default">Default</option>
>-							[% FOREACH frameworkcodeloo IN frameworkcodeloop %]                                             
>-                                <option value="[% frameworkcodeloo.value %]" [% frameworkcodeloo.selected %]>
>+							[% FOREACH frameworkcodeloo IN frameworkcodeloop %]
>+                                [% IF ( frameworkcodeloo.selected ) %]
>+                                    <option value="[% frameworkcodeloo.value %]" selected="selected">
>+                                [% ELSE %]
>+                                    <option value="[% frameworkcodeloo.value %]">
>+                                [% END %]
> 					             [% frameworkcodeloo.frameworktext %]                                      
>                                  </option>                          
> 					        [% END %]
>-- 
>1.7.3
>

Actions: View | Diff | Splinter Review

Attachments on bug 6458: 4695 | 4697 | 4699 | 4729 | 4968 | 5070 | 5071 | 5072 | 5074 | 5078 | 5079 | 5080 | 5081 | 5082 | 5090 | 5091 | 5092 | 5093 | 5094 | 5095 | 5096 | 5121 | 5125 | 5126 | 5127 | 5128 | 5129 | 5130 | 5131 | 5132 | 5133 | 5147 | 5148 | 5149 | 5150 | 5152 | 5153 | 5155 | 5156 | 5157 | 5158 | 5159 | 5160 | 5168 | 5169 | 5170 | 5258 | 5259 | 5260 | 5261 | 5262 | 5263 | 5273 | 5274 | 5286 | 5287 | 5288 | 5289 | 5292 | 5293 | 5299 | 5300 | 5416 | 5417 | 5418 | 5419 | 5420 | 5425 | 5426 | 5427