Attachment 54275 Details for Bug 17091 – [SIGNED-OFF]Bug 17091: Remove explicit declaration of Koha::Objects->pager

[patch] [SIGNED-OFF]Bug 17091: Remove explicit declaration of Koha::Objects->pager

SIGNED-OFFBug-17091-Remove-explicit-declaration-of.patch (text/plain), 1.70 KB, created by Héctor Eduardo Castro Avalos on 2016-08-10 14:44:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Héctor Eduardo Castro Avalos

Created: 2016-08-10 14:44:30 UTC

Size: 1.70 KB

patch

obsolete

>From 1bd90db9bea283458d1ced8948672c575a2fa114 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 9 Aug 2016 15:54:58 +0100
>Subject: [PATCH] [SIGNED-OFF]Bug 17091: Remove explicit declaration of
> Koha::Objects->pager
>
>Test plan:
>  prove t/db_dependent/Koha/Objects.t
>should return green
>
>Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
>---
> Koha/Objects.pm               |   11 -----------
> t/db_dependent/Koha/Objects.t |    8 +++++++-
> 2 files changed, 7 insertions(+), 12 deletions(-)
>
>diff --git a/Koha/Objects.pm b/Koha/Objects.pm
>index 0dba0e01..a1ee20d 100644
>--- a/Koha/Objects.pm
>+++ b/Koha/Objects.pm
>@@ -130,17 +130,6 @@ sub search {
>     }
> }
> 
>-=head3 Koha::Objects->pager();
>-
>-my $pager = Koha::Objects->pager;
>-
>-=cut
>-
>-sub pager {
>-    my ( $self ) = @_;
>-    return $self->_resultset->pager;
>-}
>-
> =head3 Koha::Objects->next();
> 
> my $object = Koha::Objects->next();
>diff --git a/t/db_dependent/Koha/Objects.t b/t/db_dependent/Koha/Objects.t
>index 3551caa..bb75747 100644
>--- a/t/db_dependent/Koha/Objects.t
>+++ b/t/db_dependent/Koha/Objects.t
>@@ -19,7 +19,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 3;
>+use Test::More tests => 4;
> 
> use Koha::Authority::Types;
> use Koha::Cities;
>@@ -51,5 +51,11 @@ subtest 'update' => sub {
>     is( Koha::Cities->search( { city_country => 'UK' } )->count, 0, 'Koha::Objects->update should have updated the 3 rows' );
> };
> 
>+subtest 'pager' => sub {
>+    plan tests => 1;
>+    my $pager = Koha::Patrons->search( {}, { page => 1, rows => 2 } )->pager;
>+    is( ref($pager), 'DBIx::Class::ResultSet::Pager', 'Koha::Objects->pager returns a valid DBIx::Class object' );
>+};
>+
> $schema->storage->txn_rollback;
> 1;
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 17091: 54217 | 54218 | 54219 | 54220 | 54221 | 54223 | 54272 | 54273 | 54274 | 54275 | 54276 | 54277 | 55378 | 56142 | 56143 | 56144 | 56145 | 56146 | 56147 | 56148