Attachment 54358 Details for Bug 13134 – Bug 13134 - Add patron category to returns confirmation dialogs

[patch] Bug 13134 - Add patron category to returns confirmation dialogs

Bug-13134---Add-patron-category-to-returns-confirm.patch (text/plain), 5.61 KB, created by Jonathan Druart on 2016-08-12 11:13:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-08-12 11:13:18 UTC

Size: 5.61 KB

patch

obsolete

>From 588f4d075461bdb598c41e16b2befa6ce85e3963 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 14 Oct 2011 10:37:56 -0400
>Subject: [PATCH] Bug 13134 - Add patron category to returns confirmation
> dialogs
>
>Some librarians find it useful to know what category a patron is before
>confirming a reserve or transfer from the checkin screen.
>
>This patch adds the patron category to the hold and transfer popups
>to the patron information already displayed. The li tags that contain
>the patron category have the class "patron-category" to allow this data
>to be easily hidden.
>
>Test Plan:
>1) Apply this patch
>2) Trap a hold for a patron, note the patron category is now displayed
>3) Trap a hold for pickup at another loation, note the patron category
>   is now displayed
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> circ/returns.pl                                         |  3 +++
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 10 +++++-----
> 2 files changed, 8 insertions(+), 5 deletions(-)
>
>diff --git a/circ/returns.pl b/circ/returns.pl
>index 418f94e..5143780 100755
>--- a/circ/returns.pl
>+++ b/circ/returns.pl
>@@ -178,6 +178,7 @@ if ( $query->param('resbarcode') ) {
>             borcnum        => $borr->{'cardnumber'},
>             borfirstname   => $borr->{'firstname'},
>             borsurname     => $borr->{'surname'},
>+            borcategory    => $borr->{'description'},
>             diffbranch     => 1,
>         );
>     }
>@@ -409,6 +410,7 @@ if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'}) {
>             wname           => $name,
>             wborfirstname   => $borr->{'firstname'},
>             wborsurname     => $borr->{'surname'},
>+            wborcategory    => $borr->{'description'},
>             wbortitle       => $borr->{'title'},
>             wborphone       => $borr->{'phone'},
>             wboremail       => $borr->{'email'},
>@@ -453,6 +455,7 @@ if ( $messages->{'ResFound'}) {
>             name           => $borr->{'surname'} . ", " . $borr->{'title'} . " " . $borr->{'firstname'},
>             borfirstname   => $borr->{'firstname'},
>             borsurname     => $borr->{'surname'},
>+            borcategory    => $borr->{'description'},
>             bortitle       => $borr->{'title'},
>             borphone       => $borr->{'phone'},
>             boremail       => $borr->{'email'},
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index f0d584b..b9061ac 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -217,8 +217,8 @@ $(document).ready(function () {
>         <button class="deny" type="submit" onclick="window.location.href='/cgi-bin/koha/circ/returns.pl?itemnumber=[% itemnumber %]&amp;canceltransfer=1'"><i class="fa fa-times"></i> Cancel transfer</button>
> [% IF ( wborcnum ) %]<h5>Hold for:</h5>
>         <ul><li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">
>-            [% borsurname %], [% borfirstname %]</a> ([% borcnum %])</li>
>-        <li>[% wborstnum %] [% wboraddress %][% IF ( wboraddress2 ) %]<br />
>+            [% borsurname %], [% borfirstname %]</a> ([% borcnum %]) <span class="patron-category"> - [% wborcategory %]</span> </li>
>+                <li>[% wborstnum %] [% wboraddress %][% IF ( wboraddress2 ) %]<br />
> 		[% wboraddress2 %]<br />[% END %]
>         [% wborcity %]  [% wborzip %]</li>
>         [% IF ( wborphone ) %]<li>[% wborphone %]</li>[% END %]
>@@ -252,7 +252,7 @@ $(document).ready(function () {
>         [% IF ( reservenotes ) %]<h4>Notes: [% reservenotes %]</h4>[% END %]
>         <h4>Hold for:</h4>
> 			<ul>
>-            <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borsurname %], [% borfirstname %]</a> ([% borcnum %])</li>
>+            <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borsurname %], [% borfirstname %]</a> ([% borcnum %]) <span class="patron-category"> - [% wborcategory %]</span> </li>
>             <li>[% borstnum %] [% boraddress %]<br />
> 			[% IF ( boraddress2 ) %][% boraddress2 %]<br />[% END %]
>             [% borcity %] [% borzip %]</li>
>@@ -301,7 +301,7 @@ $(document).ready(function () {
>                 <p><a href="/cgi-bin/koha/catalogue/detail.pl?type=intra&amp;biblionumber=[% itembiblionumber %]">[% itembarcode |html %]: [% title |html %]</a></p>
>                 <h4>Hold for: </h4>
>                     <ul>
>-                        <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borsurname %], [% borfirstname %]</a> ([% borcnum %])</li>
>+                        <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borsurname %], [% borfirstname %]</a> ([% borcnum %]) <span class="patron-category"> - [% wborcategory %]</span> </li>
>                         <li>[% borstnum %] [% boraddress %]<br />
> 						[% IF ( boraddress2 ) %][% boraddress2 %]<br />[% END %]
> 						[% borcity %]  [% borzip %]</li>
>@@ -413,7 +413,7 @@ $(document).ready(function () {
> 		<ul>
>             <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">
>                 [% borsurname %], [% borfirstname %]
>-            </a> ([% borcnum %])</li>
>+            </a> ([% borcnum %]) <span class="patron-category"> - [% wborcategory %]</span></li>
>             <li>[% borstnum %] [% boraddress %]<br />
> 			[% IF ( boraddress2 ) %][% boraddress2 %]<br />[% END %]
> 			[% borcity %] [% borzip %]</li>
>-- 
>2.8.1

Actions: View | Diff | Splinter Review

Attachments on bug 13134: 32617 | 32618 | 32642 | 54282 | 54306 | 54307 | 54358 | 54359