Attachment 54379 Details for Bug 17117 – [SIGNED-OFF]Bug 17117: Patron personal details not displayed unless branch update request is enabled

[patch] [SIGNED-OFF]Bug 17117: Patron personal details not displayed unless branch update request is enabled

SIGNED-OFFBug-17117-Patron-personal-details-not-di.patch (text/plain), 2.30 KB, created by Héctor Eduardo Castro Avalos on 2016-08-12 15:15:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Héctor Eduardo Castro Avalos

Created: 2016-08-12 15:15:42 UTC

Size: 2.30 KB

patch

obsolete

>From cf922980ce7cdd3d48f904ec1ecb65825c59fa10 Mon Sep 17 00:00:00 2001
>From: Jacek Ablewicz <abl@biblos.pk.edu.pl>
>Date: Fri, 12 Aug 2016 16:19:52 +0200
>Subject: [PATCH] [SIGNED-OFF]Bug 17117: Patron personal details not displayed
> unless branch update request is enabled
>
>In patron acount ("your personal details" tab, which serves as a form
>for submitting update requests as well) it's not possible to display
>some account details like expiration date etc., without enabling
>the field for branch / library update requests too.
>
>To reproduce:
>
>1) set OPACPatronDetails to "Allow"
>2) clear PatronSelfModificationBorrowerUnwantedField preference
>- all possible fields in the update requests form are visible
>in patron account, including some extra details (card number,
>expiration date, category) in the "Library" section on top
>3) put 'branchcode' in PatronSelfModificationBorrowerUnwantedField preference
>4) the whole 'Library' section disappears
>
>To test:
>
>1) apply patch
>2) put 'branchcode' in PatronSelfModificationBorrowerUnwantedField,
>'Library' section should remain visible (sans branch selection option)
>3) put 'branchcode|cardnumber|datexpiry|categorycode' in the same
>preference, 'Library' section should now disappear
>
>Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
>Works as advertised
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt |    5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>index 574a5fd..8c74605 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>@@ -113,7 +113,10 @@
> 
>                 <form method="post" action="/cgi-bin/koha/opac-memberentry.pl" id="memberentry-form">
> 
>-                [% UNLESS hidden.defined('branchcode') %]
>+                [% UNLESS
>+                    ( hidden.defined('cardnumber') || ( !borrower && Koha.Preference('autoMemberNum') ) ) &&
>+                    hidden.defined('dateexpiry') && hidden.defined('branchcode') && hidden.defined('categorycode')
>+                %]
>                     <fieldset class="rows" id="memberentry_library">
> 
>                         <legend id="library_legend">Library</legend>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 17117: 54377 | 54379 | 54428