Attachment 54411 Details for Bug 16554 – Bug 16554: DO NOT PUSH - (followup) - sorted filenames

[patch] Bug 16554: DO NOT PUSH - (followup) - sorted filenames

Bug-16554-DO-NOT-PUSH---followup---sorted-filename.patch (text/plain), 1.34 KB, created by Mark Tompsett on 2016-08-13 00:05:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2016-08-13 00:05:13 UTC

Size: 1.34 KB

patch

obsolete

>From 9d80e5fb2b472e0908d1f52ac11dea4731c30dc2 Mon Sep 17 00:00:00 2001
>From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Date: Sat, 28 May 2016 00:09:20 -0300
>Subject: [PATCH] Bug 16554: DO NOT PUSH - (followup) - sorted filenames
>
>Filenames must be loaded in alphabetical order.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> t/db_dependent/Test_installer.t | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Test_installer.t b/t/db_dependent/Test_installer.t
>index 00f3a44..ec8ba33 100644
>--- a/t/db_dependent/Test_installer.t
>+++ b/t/db_dependent/Test_installer.t
>@@ -30,12 +30,13 @@ for my $lang ( qw ( de-DE en es-ES fr-CA fr-FR it-IT nb-NO pl-PL ru-RU uk-UA ) )
>         say "loading kohastructure for $lang | not $marcflavour";
>         recreate_db( $db_name );
>         my $error = C4::Installer->new->load_sql( $kohastructure );
>-        my @sample_files = @global_files;
>+        my @sample_files;
> 
>         find( sub {
>                 push @sample_files, $File::Find::name if $_ =~ m|\.sql$|;
>-            }, $sample_dir . '/' . $lang . '/'
>+            }, $sample_dir . $lang . '/'
>         );
>+        @sample_files = ( @global_files, sort @sample_files );
>         my $i = 1;
>         for my $sql_file ( @sample_files ) {
>             print $i++ . "/" . scalar @sample_files . "\r"; flush STDOUT;
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 16554: 51619 | 51620 | 51621 | 51752 | 51753 | 51754 | 51755 | 51756 | 51757 | 51840 | 51890 | 51897 | 51898 | 51899 | 51900 | 54136 | 54137 | 54399 | 54404 | 54405 | 54406 | 54407 | 54408 | 54409 | 54410 | 54411 | 54412 | 54413 | 54414 | 54415 | 54416 | 55219 | 55220 | 55221 | 55222 | 55223 | 55224 | 55225 | 55226 | 55227 | 55228 | 55229 | 55230