Attachment 54427 Details for Bug 17103 – [PASSED QA] Bug 17103 - Google API Loader jsapi called over http

[patch] [PASSED QA] Bug 17103 - Google API Loader jsapi called over http

PASSED-QA-Bug-17103---Google-API-Loader-jsapi-call.patch (text/plain), 1.90 KB, created by Katrin Fischer on 2016-08-14 12:01:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-08-14 12:01:43 UTC

Size: 1.90 KB

patch

obsolete

>From 074a85ee854728cd8d6653928c6920428897719e Mon Sep 17 00:00:00 2001
>From: "Indranil Das Gupta (L2C2 Technologies)" <indradg@l2c2.co.in>
>Date: Sat, 13 Aug 2016 05:55:14 +0530
>Subject: [PATCH] [PASSED QA] Bug 17103 - Google API Loader jsapi called over
> http
>
>This patch replaces the hardcoded protocol ("http") from the URI with
>https since that is what Google defacto uses to serve JS resources
>Prevents MIXED CONTENT failure, allowing GoogleIndicTransliteration
>to function correctly when used in SSLized OPACs.
>
>Test plan
>---------
>
>1/ Make sure your OPAC is being served both over HTTP and HTTPS
>2/ Set GoogleIndicTransliteration syspref to "Show"
>3/ Access the OPAC over http, Google transliteration element will
>   show up in masthead searchbox.
>4/ Access the OPAC over https. The element will not show. Console
>   will show MIXED CONTENT error and failure of google loader.
>5/ Apply patch. Repeat steps #3 and #4 again. Now in both cases
>   GoogleIndicTransliteration will work.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
>index 9d9af2c..3348c21 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
>@@ -209,7 +209,7 @@ $.widget.bridge('uitooltip', $.ui.tooltip);
>     </script>
> [% END %]
> [% IF ( GoogleIndicTransliteration ) %]
>-    <script type="text/javascript" src="http://www.google.com/jsapi"></script>
>+    <script type="text/javascript" src="https://www.google.com/jsapi"></script>
>     <script type="text/javascript" src="[% interface %]/[% theme %]/js/googleindictransliteration.js"></script>
> [% END %]
> [% IF persona %]
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 17103: 54321 | 54417 | 54418 | 54420 | 54427