Attachment 54432 Details for Bug 10848 – [PASSED QA] Bug 10848 - [QA Followup] Add missing branch option and fix pattern for copyrightdate

[patch] [PASSED QA] Bug 10848 - [QA Followup] Add missing branch option and fix pattern for copyrightdate

PASSED-QA-Bug-10848---QA-Followup-Add-missing-bran.patch (text/plain), 3.41 KB, created by Katrin Fischer on 2016-08-14 13:01:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-08-14 13:01:01 UTC

Size: 3.41 KB

patch

obsolete

>From cd67d2e1cb7becf9dac681e95a75eac504859fc5 Mon Sep 17 00:00:00 2001
>From: Jacek Ablewicz <abl@biblos.pk.edu.pl>
>Date: Fri, 12 Aug 2016 11:42:48 +0200
>Subject: [PATCH] [PASSED QA] Bug 10848 - [QA Followup] Add missing branch
> option and fix pattern for copyrightdate
>
>- HTML5 input pattern for copyrightdate was not taking into an account
>the database field type, which is smallint(5)
>- added title="..." for the year field so the acceptable date format
>should be displayed as a hint/tooltip in the browser
>- added an missing option for configuring branch/library as mandatory
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 1 +
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt        | 6 +++++-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index a328bd7..b640783 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -565,6 +565,7 @@ OPAC:
>                 collectiontitle: Collection title
>                 place: Publication place
>                 itemtype: Item type
>+                branch: Library or branch
>                 patronreason: Patron reason
>                 note: Note
>             - "<br />Note: if none of the above options are selected, 'Title' field would be mandatory anyway, by default."
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>index cf4dec2..3f4234f 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>@@ -42,7 +42,11 @@
>                                     <ol>
>                                         <li><label for="title">Title:</label><input type="text" id="title" name="title" class="span6" maxlength="255" /></li>
>                                         <li><label for="author">Author:</label><input type="text" id="author" name="author" class="span6" maxlength="80" /></li>
>-                                        <li><label for="copyrightdate">Copyright date:</label><input type="text" id="copyrightdate" name="copyrightdate" pattern="[12][0-9\-\?]{3}" size="4" maxlength="4" /></li>
>+                                        <li>
>+                                            <div title="Copyright or publication year, for example: 2016">
>+                                            <label for="copyrightdate">Copyright date:</label><input type="text" id="copyrightdate" name="copyrightdate" pattern="[12]\d{3}" size="4" maxlength="4" />
>+                                            </div>
>+                                        </li>
>                                         <li><label for="isbn">Standard number (ISBN, ISSN or other):</label><input type="text" id="isbn" name="isbn"  maxlength="80" /></li>
>                                         <li><label for="publishercode">Publisher:</label><input type="text" id="publishercode" name="publishercode" class="span6" maxlength="80" /></li>
>                                         <li><label for="collectiontitle">Collection title:</label><input type="text" id="collectiontitle" name="collectiontitle" class="span6" maxlength="80" /></li>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 10848: 28721 | 28722 | 28792 | 29091 | 29092 | 34317 | 34318 | 34319 | 34324 | 34325 | 34326 | 34544 | 34545 | 34546 | 34547 | 35830 | 54016 | 54017 | 54018 | 54019 | 54020 | 54021 | 54083 | 54084 | 54356 | 54430 | 54431 | 54432