Bugzilla – Attachment 5446 Details for
Bug 6679
Fixing code so it passes basic Perl::Critic tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Followup patch for acqui/histsearch.pl
0002-Bug-6679-Followup-for-acqui-histsearch.pl.patch (text/plain), 1.67 KB, created by
Frédéric Demians
on 2011-09-17 06:17:01 UTC
(
hide
)
Description:
Followup patch for acqui/histsearch.pl
Filename:
MIME Type:
Creator:
Frédéric Demians
Created:
2011-09-17 06:17:01 UTC
Size:
1.67 KB
patch
obsolete
>From 92023f7377004d948e49a49a01ad7788ad5919f9 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr> >Date: Sat, 17 Sep 2011 08:02:54 +0200 >Subject: [PATCH 2/2] Bug 6679 Followup for acqui/histsearch.pl > >--- > acqui/histsearch.pl | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) > >diff --git a/acqui/histsearch.pl b/acqui/histsearch.pl >index e158842..82ba04f 100755 >--- a/acqui/histsearch.pl >+++ b/acqui/histsearch.pl >@@ -64,8 +64,10 @@ my $author = $input->param('author'); > my $name = $input->param( 'name' ); > my $basket = $input->param( 'basket' ); > my $booksellerinvoicenumber = $input->param( 'booksellerinvoicenumber' ); >-my $from_placed_on = C4::Dates->new($input->param('from')) if $input->param('from'); >-my $to_placed_on = C4::Dates->new($input->param( 'to')) if $input->param('to'); >+my $from_placed_on = $input->param('from'); >+$from_placed_on = C4::Dates->new($from_placed_on) if $from_placed_on; >+my $to_placed_on = $input->param('to'); >+$to_placed_on = C4::Dates->new($to_placed_on) if $to_placed_on; > > my $dbh = C4::Context->dbh; > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( >@@ -103,8 +105,8 @@ if ($do_search) { > ); > } > >-my $from_date = $from_placed_on->output('syspref') if $from_placed_on; >-my $to_date = $to_placed_on->output('syspref') if $to_placed_on; >+my $from_date = $from_placed_on ? $from_placed_on->output('syspref') : undef; >+my $to_date = $to_placed_on ? $to_placed_on->output('syspref') : undef; > > $template->param( > suggestions_loop => $order_loop, >-- >1.7.6.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6679
:
4883
|
4884
|
4885
|
4886
|
4887
|
4888
|
5445
|
5446
|
5483
|
5487
|
6121
|
6122
|
6123
|
6139
|
6140
|
6141
|
6142
|
6143
|
6144
|
6270
|
6271
|
6663
|
6670
|
6675
|
6676
|
6677
|
6678
|
8542
|
8897
|
8898
|
8899
|
8950
|
8951
|
9746
|
9747
|
9748
|
9749
|
9750
|
10050
|
10051
|
10052
|
10053
|
10054
|
10075
|
10076
|
10077
|
10078
|
10079
|
10484
|
10485
|
10486
|
10487
|
10488
|
10489
|
10491
|
10492
|
10493
|
10494
|
10495
|
10496
|
10497
|
10499
|
10500
|
10501
|
10502
|
10503
|
10504
|
10505
|
10506
|
10507
|
10508
|
10509
|
10510
|
10512
|
10513
|
10514
|
10515
|
10517
|
10521
|
10522
|
10523
|
10524
|
10525
|
10526
|
10527
|
10935
|
10936
|
10938
|
10940
|
10944
|
10945
|
10946
|
10947
|
10948
|
10949
|
10950
|
10952
|
10953
|
10955
|
10957
|
10958
|
10959
|
10960
|
10961
|
10962
|
10963
|
10964
|
10965
|
10966
|
10967
|
10972
|
10976
|
10979
|
10980
|
10981
|
12224
|
12363
|
12490
|
12491
|
12492
|
34191
|
34192
|
34193
|
34194
|
34195
|
34196
|
34197
|
39100
|
39101
|
39102
|
39392
|
39393
|
39394
|
39395
|
39396
|
39397
|
39398
|
42770
|
47086
|
47087
|
47088
|
47089
|
47090
|
47178
|
47179
|
47180
|
47181
|
47205
|
47206
|
47207
|
47208