Bugzilla – Attachment 54515 Details for
Bug 14504
Add command-line script to batch delete items based on data in items table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14504: (QA followup)
Bug-14504-QA-followup.patch (text/plain), 4.63 KB, created by
Kyle M Hall (khall)
on 2016-08-16 15:55:17 UTC
(
hide
)
Description:
Bug 14504: (QA followup)
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-08-16 15:55:17 UTC
Size:
4.63 KB
patch
obsolete
>From d8ebc6f7e94a20490f563c721cc5c8dd6601c243 Mon Sep 17 00:00:00 2001 >From: Barton Chittenden <barton@bywatersolutions.com> >Date: Thu, 15 Oct 2015 13:40:29 -0700 >Subject: [PATCH] Bug 14504: (QA followup) > >* Fix POD warning. >* Remove redundant 'use stric' and 'use warnings' >* Remove $VERSION and --version option. >* Remove --dry-run option >* Split test for --help and check for @criteria into two separate pod2usage calls, > enabling -msg on the latter. >* Fix 'target_tiems' typo. >* Test for holds on items to be deleted. >* Fix whitespace >* Fix test for holds. >--- > misc/cronjobs/delete_items.pl | 58 ++++++++++++++++--------------------------- > 1 file changed, 21 insertions(+), 37 deletions(-) > >diff --git a/misc/cronjobs/delete_items.pl b/misc/cronjobs/delete_items.pl >index c6683ff..81f11c7 100755 >--- a/misc/cronjobs/delete_items.pl >+++ b/misc/cronjobs/delete_items.pl >@@ -1,7 +1,5 @@ > #! /usr/bin/perl > >-use warnings; >-use strict; > use Getopt::Long; > use C4::Context; > use C4::Items; >@@ -9,12 +7,10 @@ use C4::Circulation; > use Modern::Perl; > use Pod::Usage; > >-my $VERSION='1.0'; >- > my $dbh = C4::Context->dbh(); > > my $query = { >- target_items => q|SELECT itemnumber from items| >+ target_items => q|SELECT itemnumber, biblionumber from items| > }; > > my $GLOBAL = { >@@ -40,56 +36,52 @@ GetOptions( > , 'h|help' => sub { $OPTIONS->{flags}->{help} = 1 } > , 'm|manual' => sub { $OPTIONS->{flags}->{manual} = 1 } > , 'c|commit' => sub { $OPTIONS->{flags}->{commit} = 1 } # aka DO-EET! >- , 'dry-run' => sub { $OPTIONS->{flags}->{commit} = 0; >- $OPTIONS->{flags}->{verbose} = 1 } > ); > > my @criteria = @{ $OPTIONS->{criteria} }; > >-if( $OPTIONS->{flags}->{version} ) { >- say "$0 version $VERSION"; >- exit; >-} >- > pod2usage( -verbose => 2 ) if $OPTIONS->{flags}->{manual}; >-pod2usage(1) if ( $OPTIONS->{flags}->{help} || scalar @criteria == 0 ); >- >- >- >+pod2usage( -verbose => 1 ) if $OPTIONS->{flags}->{help}; >+pod2usage( -verbose => 1 -msg => 'You must supply at least one --criteria option' ) if scalar @criteria == 0; > > sub verbose { > say @_ if $OPTIONS->{flags}->{verbose}; > } > >- > my $where_clause = ' where ' . join ( " and ", @criteria ); > > verbose "Where statement: $where_clause"; > >-$GLOBAL->{sth}->{target_tiems} = $dbh->prepare( $query->{target_items} . $where_clause ); >-$GLOBAL->{sth}->{target_tiems}->execute(); >+$GLOBAL->{sth}->{target_items} = $dbh->prepare( $query->{target_items} . $where_clause ); >+$GLOBAL->{sth}->{target_items}->execute(); > >-DELITEM: while ( my $item = $GLOBAL->{sth}->{target_tiems}->fetchrow_hashref() ) { >+DELITEM: while ( my $item = $GLOBAL->{sth}->{target_items}->fetchrow_hashref() ) { > my $issue = GetOpenIssue( $item->{itemnumber} ); >+ my $holds = GetItemHolds( $item->{biblionumber}, $item->{itemnumber} ); >+ > if( defined $issue ) { >- verbose "Cannot delete '$item->{itemnumber}' -- item is checked out." >- } else { >- verbose "Deleting '$item->{itemnumber}' "; >- C4::Items::DelItem( { itemnumber => $item->{itemnumber} } ) if $OPTIONS->{flags}->{commit} ; >+ verbose "Cannot delete '$item->{itemnumber}' -- item is checked out."; >+ next DELITEM; > } >+ >+ if( $holds ) { >+ verbose "Cannot delete '$item->{itemnumber}' -- item has open holds."; >+ next DELITEM; >+ } >+ >+ verbose "Deleting '$item->{itemnumber}' "; >+ C4::Items::DelItem( { itemnumber => $item->{itemnumber} } ) if $OPTIONS->{flags}->{commit} ; > } > > =head1 NAME > >- delete_items.pl - A batch item deletion tool, which generates a query against >- the items database and deletes the items matching the >- criteria specified in the command line arguments. >+delete_items.pl - A batch item deletion tool, which generates a query against the items database and deletes the items matching the criteria specified in the command line arguments. > > =head1 SYNOPSIS > >-delete_items.pl [--help|--manual|--version] >+delete_items.pl [--help|--manual] > >-delete_items.pl [--verbose] [--dry-run] --criteria "I<SQL CONDITIONAL EXPRESSION>" ... [--commit] >+delete_items.pl [--verbose] --criteria "I<SQL CONDITIONAL EXPRESSION>" ... [--commit] > > =cut > >@@ -105,10 +97,6 @@ Show the brief help information. > > Read the manual, with examples. > >-=item B<--version> >- >-Show the version number and exit. >- > =item B<--verbose> > > Send the "WHERE" clause generated by the collected C<--criteria> >@@ -124,10 +112,6 @@ clause querying the items table. These are joined by C<AND>. > > No items will be deleted unless the C<--commit> flag is present. > >-=item B<--dry-run> >- >-Disables C<--commit> flag and enables C<--verbose> flag. >- > =back > > =cut >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14504
:
40830
|
42978
|
43445
|
43533
|
43788
|
43789
|
44013
|
44149
|
45789
|
49648
|
49649
|
49650
|
49651
|
49652
|
49653
|
52425
|
53224
|
53225
|
54514
|
54515
|
54516
|
54517
|
54518
|
54519
|
54520
|
54521
|
54522
|
54525
|
54530
|
54531
|
54691
|
54692
|
54693
|
54694
|
54695
|
54696
|
54697
|
54698
|
54699
|
54700
|
54701
|
54702
|
54703