Bugzilla – Attachment 54531 Details for
Bug 14504
Add command-line script to batch delete items based on data in items table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14504: (QA followup) Change argument --criteria to --where
Bug-14504-QA-followup-Change-argument---criteria-t.patch (text/plain), 3.32 KB, created by
Barton Chittenden
on 2016-08-16 20:39:57 UTC
(
hide
)
Description:
Bug 14504: (QA followup) Change argument --criteria to --where
Filename:
MIME Type:
Creator:
Barton Chittenden
Created:
2016-08-16 20:39:57 UTC
Size:
3.32 KB
patch
obsolete
>From 6b4f4ef102e08822806027f1f951c23e62da8b5b Mon Sep 17 00:00:00 2001 >From: Barton Chittenden <barton@bywatersolutions.com> >Date: Tue, 16 Aug 2016 20:36:49 +0000 >Subject: [PATCH] Bug 14504: (QA followup) Change argument --criteria to > --where > >--- > misc/cronjobs/delete_items.pl | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > >diff --git a/misc/cronjobs/delete_items.pl b/misc/cronjobs/delete_items.pl >index 88a6bc0..7d15560 100755 >--- a/misc/cronjobs/delete_items.pl >+++ b/misc/cronjobs/delete_items.pl >@@ -19,7 +19,7 @@ my $GLOBAL = { > }; > > my $OPTIONS = { >- criteria => [] >+ where => [] > , flags => { > verbose => '' > , commit => '' >@@ -30,7 +30,7 @@ my $OPTIONS = { > }; > > GetOptions( >- 'criteria=s' => $OPTIONS->{criteria} >+ 'where=s' => $OPTIONS->{where} > , 'v|verbose' => sub { $OPTIONS->{flags}->{verbose} = 1 } > , 'V|version' => sub { $OPTIONS->{flags}->{version} = 1 } > , 'h|help' => sub { $OPTIONS->{flags}->{help} = 1 } >@@ -38,17 +38,17 @@ GetOptions( > , 'c|commit' => sub { $OPTIONS->{flags}->{commit} = 1 } # aka DO-EET! > ); > >-my @criteria = @{ $OPTIONS->{criteria} }; >+my @where = @{ $OPTIONS->{where} }; > > pod2usage( -verbose => 2 ) if $OPTIONS->{flags}->{manual}; > pod2usage( -verbose => 1 ) if $OPTIONS->{flags}->{help}; >-pod2usage( -verbose => 1 -msg => 'You must supply at least one --criteria option' ) if scalar @criteria == 0; >+pod2usage( -verbose => 1 -msg => 'You must supply at least one --where option' ) if scalar @where == 0; > > sub verbose { > say @_ if $OPTIONS->{flags}->{verbose}; > } > >-my $where_clause = ' where ' . join ( " and ", @criteria ); >+my $where_clause = ' where ' . join ( " and ", @where ); > > verbose "Where statement: $where_clause"; > >@@ -74,7 +74,7 @@ delete_items.pl - A batch item deletion tool, which generates a query against th > > delete_items.pl [--help|--manual] > >-delete_items.pl [--verbose] --criteria "I<SQL CONDITIONAL EXPRESSION>" ... [--commit] >+delete_items.pl [--verbose] --where "I<SQL CONDITIONAL EXPRESSION>" ... [--commit] > > =cut > >@@ -92,12 +92,12 @@ Read the manual, with examples. > > =item B<--verbose> > >-Send the "WHERE" clause generated by the collected C<--criteria> >+Send the "WHERE" clause generated by the collected C<--where> > arguments, as well as items affected to Standard Out. > >-=item B<--criteria> >+=item B<--where> > >-The C<--criteria> option may called multiple times. The following argument >+The C<--where> option may called multiple times. The following argument > must be a syntactically valid SQL statement which is part of the C<WHERE> > clause querying the items table. These are joined by C<AND>. > >@@ -114,9 +114,9 @@ No items will be deleted unless the C<--commit> flag is present. > > The following is an example of this script: > >- delete_items.pl --criteria "items.withdrawn ! 0" --criteria "items.withdrawn_on < $(date --date="13 month ago" --rfc-3339=date)" --commit >+ delete_items.pl --where "items.withdrawn ! 0" --where "items.withdrawn_on < $(date --date="13 month ago" --rfc-3339=date)" --commit > >- delete_items.pl --criteria "itemlost >= '1'" --criteria "itemlost <='4'" --criteria "itemlost_on < '2014-04-28'" --commit >+ delete_items.pl --where "itemlost >= '1'" --where "itemlost <='4'" --where "itemlost_on < '2014-04-28'" --commit > > =cut > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14504
:
40830
|
42978
|
43445
|
43533
|
43788
|
43789
|
44013
|
44149
|
45789
|
49648
|
49649
|
49650
|
49651
|
49652
|
49653
|
52425
|
53224
|
53225
|
54514
|
54515
|
54516
|
54517
|
54518
|
54519
|
54520
|
54521
|
54522
|
54525
|
54530
|
54531
|
54691
|
54692
|
54693
|
54694
|
54695
|
54696
|
54697
|
54698
|
54699
|
54700
|
54701
|
54702
|
54703