Bugzilla – Attachment 54596 Details for
Bug 14390
Fine not updated from 'FU' to 'F' on renewal
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14390: [QA Follow-up] UpdateFine should be passed a hash
Bug-14390-QA-Follow-up-UpdateFine-should-be-passed.patch (text/plain), 2.11 KB, created by
Marcel de Rooy
on 2016-08-19 08:16:10 UTC
(
hide
)
Description:
Bug 14390: [QA Follow-up] UpdateFine should be passed a hash
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-08-19 08:16:10 UTC
Size:
2.11 KB
patch
obsolete
>From daa845f20714cec66081476c43b6750e07e46a1a Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 19 Aug 2016 09:57:13 +0200 >Subject: [PATCH] Bug 14390: [QA Follow-up] UpdateFine should be passed a hash >Content-Type: text/plain; charset=utf-8 > >Renewing an overdue would not work. >Log shows: >renew: Can't use string ("2144746608") as a HASH ref while "strict refs" in use at C4/Overdues.pm line 508., referer: /cgi-bin/koha/circ/circulation.pl?borrowernumber=1 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Circulation.pm | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 6c957a2..0964050 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -4086,15 +4086,28 @@ sub _CalculateAndUpdateFine { > > if ( C4::Context->preference('finesMode') eq 'production' ) { > if ( $amount > 0 ) { >- C4::Overdues::UpdateFine( $issue->{itemnumber}, $issue->{borrowernumber}, >- $amount, $type, output_pref($datedue) ); >+ C4::Overdues::UpdateFine({ >+ issue_id => $issue->{issue_id}, >+ itemnumber => $issue->{itemnumber}, >+ borrowernumber => $issue->{borrowernumber}, >+ amount => $amount, >+ type => $type, >+ due => output_pref($datedue), >+ }); > } > elsif ($return_date) { > > # Backdated returns may have fines that shouldn't exist, > # so in this case, we need to drop those fines to 0 > >- C4::Overdues::UpdateFine( $issue->{itemnumber}, $issue->{borrowernumber}, 0, $type, output_pref($datedue) ); >+ C4::Overdues::UpdateFine({ >+ issue_id => $issue->{issue_id}, >+ itemnumber => $issue->{itemnumber}, >+ borrowernumber => $issue->{borrowernumber}, >+ amount => 0, >+ type => $type, >+ due => output_pref($datedue), >+ }); > } > } > } >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14390
:
41428
|
44600
|
44603
|
45280
|
45281
|
45285
|
47465
|
51627
|
51628
|
51629
|
54593
|
54594
|
54595
|
54596
|
54704
|
54778
|
54779
|
54821
|
54822
|
54823
|
54824
|
54825