Attachment 5460 Details for Bug 6885 – Proposed patch

[patch] Proposed patch

0001-Bug-6885-Allow-superlib-to-delete-items-from-any-lib.patch (text/plain), 1.63 KB, created by Frédéric Demians on 2011-09-19 18:12:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Demians

Created: 2011-09-19 18:12:26 UTC

Size: 1.63 KB

patch

obsolete

>From 423af53df22bc3862ecf3b28995b2bf96c562707 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr>
>Date: Mon, 19 Sep 2011 19:53:38 +0200
>Subject: [PATCH] Bug 6885 Allow superlib to delete items from any library
>
>When IndependantBranches syspref is enabled, a 'regular' user can only
>delete items belonging to his/her library. But a superlibrarian should
>have the permission to delete items from all libraries. He can't for the
>time being. This is fix by this patch.
>
>How to test?
>
>- On a multi-libraries Koha, activate IndependantBranches
>- Log in with a superlibrarian user
>- Find a biblio with one item from another library than the user home
>  library
>- Click on Edit > Edit Items
>- On the list of items, all lines have Delete link
>- If you try to delete an item from another library than the user home
>  library, deletion will fail.
>---
> C4/Items.pm |    6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Items.pm b/C4/Items.pm
>index bc36dd1..4aabf3d 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -2100,7 +2100,11 @@ sub DelItemCheck {
>     if ($onloan) {
>         $error = "book_on_loan";
>     }
>-    elsif (C4::Context->preference("IndependantBranches") and (C4::Context->userenv->{branch} ne $item->{C4::Context->preference("HomeOrHoldingBranch")||'homebranch'})){
>+    elsif ( C4::Context->userenv->{flags} != 1 and
>+            C4::Context->preference("IndependantBranches") and
>+           (C4::Context->userenv->{branch} ne
>+             $item->{C4::Context->preference("HomeOrHoldingBranch")||'homebranch'}) )
>+    {
>         $error = "not_same_branch";
>     } 
>     else {
>-- 
>1.7.6.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 6885: 5460 | 5771 | 5839 | 5857 | 7039 | 7046 | 7047