Bugzilla – Attachment 54750 Details for
Bug 15899
Remove the use of recordpayment
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15899 - Remove C4::Accounts::recordpayment
Bug-15899---Remove-C4Accountsrecordpayment.patch (text/plain), 1.90 KB, created by
Josef Moravec
on 2016-08-23 09:41:47 UTC
(
hide
)
Description:
Bug 15899 - Remove C4::Accounts::recordpayment
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2016-08-23 09:41:47 UTC
Size:
1.90 KB
patch
obsolete
>From ace7e0be501f30dcaed2b0d8f1d5f459d0a49c1a Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 24 Feb 2016 15:05:01 +0000 >Subject: [PATCH] Bug 15899 - Remove C4::Accounts::recordpayment > >Test Plan: >1) Apply this patch >2) prove t/db_dependent/Accounts.t >3) git grep recordpayment should show no calls to the recordpayment sub > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > C4/Accounts.pm | 28 ---------------------------- > 1 file changed, 28 deletions(-) > >diff --git a/C4/Accounts.pm b/C4/Accounts.pm >index e217453..ee1bc55 100644 >--- a/C4/Accounts.pm >+++ b/C4/Accounts.pm >@@ -35,7 +35,6 @@ BEGIN { > require Exporter; > @ISA = qw(Exporter); > @EXPORT = qw( >- &recordpayment > &makepayment > &manualinvoice > &getnextacctno >@@ -68,33 +67,6 @@ patron. > > =head1 FUNCTIONS > >-=head2 recordpayment >- >- &recordpayment($borrowernumber, $payment, $sip_paytype, $note); >- >-Record payment by a patron. C<$borrowernumber> is the patron's >-borrower number. C<$payment> is a floating-point number, giving the >-amount that was paid. C<$sip_paytype> is an optional flag to indicate this >-payment was made over a SIP2 interface, rather than the staff client. The >-value passed is the SIP2 payment type value (message 37, characters 21-22) >- >-Amounts owed are paid off oldest first. That is, if the patron has a >-$1 fine from Feb. 1, another $1 fine from Mar. 1, and makes a payment >-of $1.50, then the oldest fine will be paid off in full, and $0.50 >-will be credited to the next one. >- >-=cut >- >-#' >-sub recordpayment { >- >- #here we update the account lines >- my ( $borrowernumber, $data, $sip_paytype, $payment_note ) = @_; >- >- return Koha::Account->new( { patron_id => $borrowernumber } ) >- ->pay( { amount => $data, sip => $sip_paytype, note => $payment_note } ); >-} >- > =head2 makepayment > > &makepayment($accountlines_id, $borrowernumber, $acctnumber, $amount, $branchcode); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15899
:
48343
|
48344
|
48345
|
52137
|
52146
|
52147
|
54749
|
54750
|
55878
|
55879