Bugzilla – Attachment 54814 Details for
Bug 17188
Koha does not support several memcached servers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17188: Fix support of several memcached servers
Bug-17188-Fix-support-of-several-memcached-servers.patch (text/plain), 1.64 KB, created by
Jonathan Druart
on 2016-08-24 11:33:41 UTC
(
hide
)
Description:
Bug 17188: Fix support of several memcached servers
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-08-24 11:33:41 UTC
Size:
1.64 KB
patch
obsolete
>From 915d4483ab233e9894a5480cb133463b05a14034 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 23 Jun 2016 09:33:02 +0100 >Subject: [PATCH] Bug 17188: Fix support of several memcached servers > >There is a bug in the initialisation of memcached, the server string is >not correctly parsed. >If several memcached servers are defined, they are separated by commas >and so the string should be split accordingly > >Test plan: >1/ Set MEMCACHED_SERVERS='localhost:11211,localhost:11222' >2/ Set DEBUG=1 >3/ Reload plack, and check the log >=> Without this patch, you see > Memcached server settings: localhost:11211,localhost:11222 with koha > Selected caching system: Cache::Memory=HASH(0x9de2034) >i.e. Memcached has not been configured correctly and the default caching >system is used (Cache::Memory) >=> With this patch, you should see >Memcached server settings: localhost:11211, localhost:11222 with koha >Selected caching system: Cache::Memcached::Fast=SCALAR(0xa2a0c54) >i.e. Memcached has been configured correctly \o/ > >Note that the cache_servers attribute is never set and it not used. It's >better to remove it. >--- > Koha/Cache.pm | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/Koha/Cache.pm b/Koha/Cache.pm >index fa4f136..34c793f 100644 >--- a/Koha/Cache.pm >+++ b/Koha/Cache.pm >@@ -122,10 +122,7 @@ sub new { > > sub _initialize_memcached { > my ($self) = @_; >- my @servers = >- split /,/, $self->{'cache_servers'} >- ? $self->{'cache_servers'} >- : ($ENV{MEMCACHED_SERVERS} || ''); >+ my @servers = split /,/, $ENV{MEMCACHED_SERVERS} || ''; > return if !@servers; > > $ENV{DEBUG} >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17188
: 54814