Bugzilla – Attachment 54839 Details for
Bug 16035
MARC framework Export misbehaving
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16035: MARC default bibliographic framework Export fix
Bug-16035-MARC-default-bibliographic-framework-Exp.patch (text/plain), 1.38 KB, created by
Aleisha Amohia
on 2016-08-24 21:29:32 UTC
(
hide
)
Description:
Bug 16035: MARC default bibliographic framework Export fix
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2016-08-24 21:29:32 UTC
Size:
1.38 KB
patch
obsolete
>From 7301adc43e9d076462fa720acada3b76cf30e4f9 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Wed, 24 Aug 2016 21:24:45 +0000 >Subject: [PATCH] Bug 16035: MARC default bibliographic framework Export fix > >This patch makes sure that, if there is no framework code passed, then >'default' is passed. At the moment, no framework code was being passed >so the code broke and triggered some warns too. > >To test: >1) Go to Admin -> MARC Bibliographic framework >2) Try to export default framework in all formats, notice the file is >only exported as .ods and is an empty file. Notice warns in intranet >error log. >3) Apply patch and refresh page >4) Confirm exporting default framework works in all formats and >spreadsheet has data >5) Notice warns in error log are gone >6) Confirm export still works for other frameworks > >Sponsored-by: Catalyst IT >--- > admin/import_export_framework.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/admin/import_export_framework.pl b/admin/import_export_framework.pl >index 41511b4..b58e91c 100755 >--- a/admin/import_export_framework.pl >+++ b/admin/import_export_framework.pl >@@ -46,7 +46,7 @@ unless ($authenticated) { > exit 0; > } > >-my $frameworkcode = $input->param('frameworkcode') || ''; >+my $frameworkcode = $input->param('frameworkcode') || 'default'; > my $action = $input->param('action') || 'export'; > > ## Exporting >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16035
:
48910
|
54839
|
54898
|
55039
|
55142