Attachment 54867 Details for Bug 15758 – Bug 15758: Koha::Libraries - Add tests for the Branches TT plugin

[patch] Bug 15758: Koha::Libraries - Add tests for the Branches TT plugin

Bug-15758-KohaLibraries---Add-tests-for-the-Branch.patch (text/plain), 4.95 KB, created by Jonathan Druart on 2016-08-25 12:55:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-08-25 12:55:07 UTC

Size: 4.95 KB

patch

obsolete

>From 072897bf978c213651b1a36d0a8a1dd30c824f97 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 8 Feb 2016 15:20:18 +0000
>Subject: [PATCH] Bug 15758: Koha::Libraries - Add tests for the Branches TT
> plugin
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> t/db_dependent/Template/Plugin/Branches.t | 83 ++++++++++++++++++++-----------
> 1 file changed, 54 insertions(+), 29 deletions(-)
>
>diff --git a/t/db_dependent/Template/Plugin/Branches.t b/t/db_dependent/Template/Plugin/Branches.t
>index 978340a..8fcc15f 100644
>--- a/t/db_dependent/Template/Plugin/Branches.t
>+++ b/t/db_dependent/Template/Plugin/Branches.t
>@@ -1,25 +1,47 @@
>+#!/usr/bin/perl
>+
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it under the
>+# terms of the GNU General Public License as published by the Free Software
>+# Foundation; either version 3 of the License, or (at your option) any later
>+# version.
>+#
>+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
>+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
>+# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License along
>+# with Koha; if not, see <http://www.gnu.org/licenses>.
>+
> use Modern::Perl;
> 
>-use Test::More tests => 11;
>+use Test::More tests => 14;
> 
> use C4::Context;
>-use Koha::Library;
>-use Koha::Libraries;
>-use Koha::Template::Plugin::Branches;
>-
>-my $dbh = C4::Context->dbh;
>-$dbh->{AutoCommit} = 0;
>-$dbh->{RaiseError} = 1;
>-
>-for my $i ( 1 .. 5 ) {
>-    Koha::Library->new(
>-{
>-        branchcode     => "test_br_$i",
>-        branchname     => "test_br_$i",
>-}
>-    )->store;
>+use Koha::Database;
>+
>+use t::lib::TestBuilder;
>+
>+BEGIN {
>+    use_ok('Koha::Template::Plugin::Branches');
> }
>-my $library = Koha::Libraries->search->next->unblessed;
>+
>+my $schema = Koha::Database->schema;
>+$schema->storage->txn_begin;
>+my $builder = t::lib::TestBuilder->new;
>+my $library = $builder->build({
>+    source => 'Branch',
>+    value => {
>+        branchcode => 'MYLIBRARY',
>+    }
>+});
>+my $another_library = $builder->build({
>+    source => 'Branch',
>+    value => {
>+        branchcode => 'ANOTHERLIB',
>+    }
>+});
> 
> my $plugin = Koha::Template::Plugin::Branches->new();
> ok($plugin, "initialized Branches plugin");
>@@ -35,20 +57,23 @@ is($name, '', 'received empty string as name of NULL/undefined library code');
> 
> $library = $plugin->GetLoggedInBranchcode();
> is($library, '', 'no active library if there is no active user session');
>+
> C4::Context->_new_userenv('DUMMY_SESSION_ID');
> C4::Context->set_userenv(123, 'userid', 'usercnum', 'First name', 'Surname', 'MYLIBRARY', 'My Library', 0);
> $library = $plugin->GetLoggedInBranchcode();
> is($library, 'MYLIBRARY', 'GetLoggedInBranchcode() returns active library');
> 
>-my $branches = $plugin->all;
>-my $test_branches = [ grep { $_->{branchcode} =~ m|^test_br_| } @$branches ];
>-is( scalar( @$test_branches ), 5, 'Plugin Branches should return the branches' );
>-my $selected_branches = [ grep { $_->{selected} } @$branches ];
>-is( scalar( @$selected_branches ), 0, 'Plugin Branches should not select a branch if not needed' );
>-
>-$branches = $plugin->all({selected => 'test_br_3'});
>-$test_branches = [ grep { $_->{branchcode} =~ m|^test_br_| } @$branches ];
>-is( scalar( @$test_branches ), 5, 'Plugin Branches should return the branches if selected passed' );
>-$selected_branches = [ grep { $_->{selected} } @$branches ];
>-is( scalar( @$selected_branches ), 1, 'Plugin Branches should return only 1 selected if passed' );
>-is( $selected_branches->[0]->{branchcode}, 'test_br_3', 'Plugin Branches should select the good one' );
>+C4::Context->set_preference( 'IndependentBranches', 0 );
>+my $libraries = $plugin->all();
>+ok( scalar(@$libraries) > 1, 'If IndependentBranches is not set, all libraries should be returned' );
>+is( grep ( { $_->{branchcode} eq 'MYLIBRARY'  and $_->{selected} == 1 } @$libraries ),       1, 'Without selected parameter, my library should be preselected' );
>+is( grep ( { $_->{branchcode} eq 'ANOTHERLIB' and not exists $_->{selected} } @$libraries ), 1, 'Without selected parameter, other library should not be preselected' );
>+$libraries = $plugin->all( { selected => 'ANOTHERLIB' } );
>+is( grep ( { $_->{branchcode} eq 'MYLIBRARY'  and not exists $_->{selected} } @$libraries ), 1, 'With selected parameter, my library should not be preselected' );
>+is( grep ( { $_->{branchcode} eq 'ANOTHERLIB' and $_->{selected} == 1 } @$libraries ),       1, 'With selected parameter, other library should be preselected' );
>+
>+C4::Context->set_preference( 'IndependentBranches', 1 );
>+$libraries = $plugin->all();
>+is( scalar(@$libraries), 1, 'If IndependentBranches is set, only 1 library should be returned' );
>+$libraries = $plugin->all( { unfiltered => 1 } );
>+ok( scalar(@$libraries) > 1, 'If IndependentBranches is set, all libraries should be returned if the unfiltered flag is set' );
>-- 
>2.8.1

Actions: View | Diff | Splinter Review

Attachments on bug 15758: 47746 | 47747 | 47748 | 47749 | 47750 | 47751 | 47752 | 47753 | 47759 | 47760 | 47761 | 47762 | 47763 | 47764 | 47765 | 52723 | 52724 | 52726 | 52727 | 52728 | 52729 | 52730 | 52731 | 52736 | 52788 | 52789 | 52790 | 52791 | 52792 | 52793 | 52794 | 52795 | 52913 | 52914 | 52915 | 52916 | 52917 | 52918 | 52919 | 52920 | 53893 | 53894 | 53895 | 53896 | 53897 | 53898 | 53899 | 53900 | 53997 | 53998 | 53999 | 54000 | 54001 | 54002 | 54003 | 54004 | 54029 | 54030 | 54031 | 54032 | 54033 | 54034 | 54035 | 54036 | 54037 | 54038 | 54039 | 54040 | 54041 | 54042 | 54043 | 54044 | 54861 | 54862 | 54863 | 54864 | 54865 | 54866 | 54867 | 54868 | 54908 | 54909 | 54921 | 54925 | 55061 | 55062 | 55063 | 55064 | 55065 | 55066 | 55067 | 55068 | 55069 | 55070 | 55071 | 55072 | 55073 | 55346 | 55347 | 55348 | 55349 | 55350 | 55351 | 55352 | 55353 | 55354 | 55355 | 55356 | 55357 | 55358 | 55445