Attachment 5487 Details for Bug 6679 – Bug 6679 : Enable Critic tests for authorities and fixed resulting warnings

[patch] Bug 6679 : Enable Critic tests for authorities and fixed resulting warnings

Bug-6679--Enable-Critic-tests-for-authorities-and-.patch (text/plain), 2.30 KB, created by Chris Cormack on 2011-09-21 03:53:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2011-09-21 03:53:31 UTC

Size: 2.30 KB

patch

obsolete

>From 5312bd7f88c81d138ac73d77d546ee6694657936 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Wed, 21 Sep 2011 15:52:23 +1200
>Subject: [PATCH] Bug 6679 : Enable Critic tests for authorities and fixed resulting warnings
>
>---
> authorities/authorities.pl |    8 ++++----
> authorities/detail.pl      |    2 +-
> t/00-testcritic.t          |    2 +-
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/authorities/authorities.pl b/authorities/authorities.pl
>index d4f1601..44387d9 100755
>--- a/authorities/authorities.pl
>+++ b/authorities/authorities.pl
>@@ -47,7 +47,7 @@ builds list, depending on authorised value...
> 
> =cut
> 
>-sub build_authorized_values_list ($$$$$$$) {
>+sub build_authorized_values_list {
>     my ( $tag, $subfield, $value, $dbh, $authorised_values_sth,$index_tag,$index_subfield ) = @_;
> 
>     my @authorised_values;
>@@ -321,11 +321,11 @@ Create a random value to set it into the input name
> 
> =cut
> 
>-sub CreateKey(){
>+sub CreateKey {
>     return int(rand(1000000));
> }
> 
>-sub build_tabs ($$$$$) {
>+sub build_tabs {
>     my ( $template, $record, $dbh, $encoding,$input ) = @_;
> 
>     # fill arrays
>@@ -499,7 +499,7 @@ sub build_tabs ($$$$$) {
> }
> 
> 
>-sub build_hidden_data () {
>+sub build_hidden_data {
>     # build hidden data =>
>     # we store everything, even if we show only requested subfields.
> 
>diff --git a/authorities/detail.pl b/authorities/detail.pl
>index 57e0737..d4f2c67 100755
>--- a/authorities/detail.pl
>+++ b/authorities/detail.pl
>@@ -50,7 +50,7 @@ use C4::Koha;
> 
> our ($tagslib);
> 
>-sub build_tabs ($$$$$) {
>+sub build_tabs {
>     my ( $template, $record, $dbh, $encoding,$input ) = @_;
> 
>     # fill arrays
>diff --git a/t/00-testcritic.t b/t/00-testcritic.t
>index bc7a3cd..19e53fb 100755
>--- a/t/00-testcritic.t
>+++ b/t/00-testcritic.t
>@@ -16,7 +16,7 @@ my @all_koha_dirs = qw( acqui admin authorities basket C4 catalogue cataloguing
> labels members misc offline_circ opac patroncards reports reserve reviews rotating_collections
> serials sms suggestion t tags test tools virtualshelves);
> 
>-my @dirs = qw( acqui admin basket circ debian errors offline_circ reserve reviews rotating_collections
>+my @dirs = qw( acqui admin authorities basket circ debian errors offline_circ reserve reviews rotating_collections
> serials sms virtualshelves );
> 
> if ( not $ENV{TEST_QA} ) {
>-- 
>1.7.4.1

Actions: View | Diff | Splinter Review

Attachments on bug 6679: 4883 | 4884 | 4885 | 4886 | 4887 | 4888 | 5445 | 5446 | 5483 | 5487 | 6121 | 6122 | 6123 | 6139 | 6140 | 6141 | 6142 | 6143 | 6144 | 6270 | 6271 | 6663 | 6670 | 6675 | 6676 | 6677 | 6678 | 8542 | 8897 | 8898 | 8899 | 8950 | 8951 | 9746 | 9747 | 9748 | 9749 | 9750 | 10050 | 10051 | 10052 | 10053 | 10054 | 10075 | 10076 | 10077 | 10078 | 10079 | 10484 | 10485 | 10486 | 10487 | 10488 | 10489 | 10491 | 10492 | 10493 | 10494 | 10495 | 10496 | 10497 | 10499 | 10500 | 10501 | 10502 | 10503 | 10504 | 10505 | 10506 | 10507 | 10508 | 10509 | 10510 | 10512 | 10513 | 10514 | 10515 | 10517 | 10521 | 10522 | 10523 | 10524 | 10525 | 10526 | 10527 | 10935 | 10936 | 10938 | 10940 | 10944 | 10945 | 10946 | 10947 | 10948 | 10949 | 10950 | 10952 | 10953 | 10955 | 10957 | 10958 | 10959 | 10960 | 10961 | 10962 | 10963 | 10964 | 10965 | 10966 | 10967 | 10972 | 10976 | 10979 | 10980 | 10981 | 12224 | 12363 | 12490 | 12491 | 12492 | 34191 | 34192 | 34193 | 34194 | 34195 | 34196 | 34197 | 39100 | 39101 | 39102 | 39392 | 39393 | 39394 | 39395 | 39396 | 39397 | 39398 | 42770 | 47086 | 47087 | 47088 | 47089 | 47090 | 47178 | 47179 | 47180 | 47181 | 47205 | 47206 | 47207 | 47208