Attachment 54890 Details for Bug 16699 – Bug 16699: Remove requirement from borrowernumberQueryParam

[patch] Bug 16699: Remove requirement from borrowernumberQueryParam

Bug-16699-Remove-requirement-from-borrowernumberQu.patch (text/plain), 1.16 KB, created by Tomás Cohen Arazi (tcohen) on 2016-08-25 18:20:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2016-08-25 18:20:21 UTC

Size: 1.16 KB

patch

obsolete

>From 97f0e1b53db71e08dc9036b250b485417dcb25ac Mon Sep 17 00:00:00 2001
>From: Lari Taskula <larit@student.uef.fi>
>Date: Thu, 11 Aug 2016 15:51:38 +0300
>Subject: [PATCH] Bug 16699: Remove requirement from borrowernumberQueryParam
>
>borrowernumberQueryParam shouldn't be required as also changed in Bug 16271.
>
>To test:
>1. Don't apply the patch yet, but first minify Swagger and run
>   t/db_dependent/api/v1/holds.t
>2. Observe that some tests fail with response code 400 when expecting 200.
>3. Apply patch and minify Swagger
>4. Run t/db_dependent/api/v1/holds.t
>5. Observe that tests pass.
>
>Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> api/v1/swagger/parameters/patron.json | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/api/v1/swagger/parameters/patron.json b/api/v1/swagger/parameters/patron.json
>index 2b204c1..409d0b2 100644
>--- a/api/v1/swagger/parameters/patron.json
>+++ b/api/v1/swagger/parameters/patron.json
>@@ -10,7 +10,6 @@
>     "name": "borrowernumber",
>     "in": "query",
>     "description": "Internal borrower identifier",
>-    "required": true,
>     "type": "integer"
>   }
> }
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 16699: 52375 | 52376 | 52377 | 52378 | 52379 | 52380 | 52580 | 52581 | 52956 | 52957 | 52958 | 52959 | 52960 | 52961 | 52962 | 52974 | 52975 | 52976 | 52978 | 52979 | 52980 | 52986 | 52987 | 52988 | 52989 | 52990 | 52991 | 54299 | 54300 | 54301 | 54302 | 54303 | 54304 | 54311 | 54372 | 54884 | 54885 | 54886 | 54887 | 54888 | 54889 | 54890 | 54891 | 54892