Bugzilla – Attachment 54924 Details for
Bug 11019
Require some fields when adding authorized value category
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11019 - Require some fields when adding authorized value category
Bug-11019---Require-some-fields-when-adding-author.patch (text/plain), 2.70 KB, created by
Owen Leonard
on 2016-08-26 12:48:18 UTC
(
hide
)
Description:
Bug 11019 - Require some fields when adding authorized value category
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2016-08-26 12:48:18 UTC
Size:
2.70 KB
patch
obsolete
>From 867d92256b1d46b0a39f45df62392acbe14585eb Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 18 Aug 2016 11:58:42 -0400 >Subject: [PATCH] Bug 11019 - Require some fields when adding authorized value > category >Content-Type: text/plain; charset="utf-8" > >This patch modifies the form for adding an authorized value so that >category, authorized value, and description are required fields. >Previously a new authorized value category could be saved with no data. > >To test, apply the patch and go to Administration -> Authorized values. > >- Click the "New category" button. >- Click the save button without filling in category, authorized value, > or description. You should be prevented from submitting the form. >- Verify that filling in the required fields allows the form to be > submitted. >- Perform the same test when editing an existing authorized value. > >Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> > >Follow-up for QA: Allow a blank authorised value to be created. >--- > .../intranet-tmpl/prog/en/modules/admin/authorised_values.tt | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt >index 764fb53..2aa3b5f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt >@@ -76,12 +76,14 @@ $(document).ready(function() { > > [% IF ( action_modify ) %]<div class="note"><i class="fa fa-exclamation"></i> <strong>NOTE:</strong> If you change an authorized value code, existing records using it won't be updated. Changes to value descriptions will show immediately.</div>[% END %] > >- <form action="/cgi-bin/koha/admin/authorised_values.pl" name="Aform" method="post"> >+ <form action="/cgi-bin/koha/admin/authorised_values.pl" name="Aform" method="post" class="validated"> > <input type="hidden" name="op" value="add" /> > <fieldset class="rows"><ol> > <li> >- [% IF ( action_add_category ) %]<label for="category">Category: </label> >- <input type="text" name="category" id="category" size="32" maxlength="32" class="focus" /> >+ [% IF ( action_add_category ) %] >+ <label for="category" class="required">Category: </label> >+ <input type="text" name="category" id="category" size="32" maxlength="32" class="focus required" /> >+ <span class="required">Required</span> > [% ELSE %]<span class="label">Category</span> > <input type="hidden" name="category" value="[% category %]" /> [% category %] > [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11019
:
21890
|
21899
|
22096
|
22097
|
22110
|
54577
|
54723
|
54761
|
54924
|
54948