Bugzilla – Attachment 54969 Details for
Bug 17211
Remove use of onclick from OPAC fines page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17211: Remove use of onclick from OPAC fines page
Bug-17211-Remove-use-of-onclick-from-OPAC-fines-pa.patch (text/plain), 2.66 KB, created by
Aleisha Amohia
on 2016-08-29 06:35:48 UTC
(
hide
)
Description:
Bug 17211: Remove use of onclick from OPAC fines page
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2016-08-29 06:35:48 UTC
Size:
2.66 KB
patch
obsolete
>From f3b916fd27916d30519126baa53da2aa14280d21 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Mon, 29 Aug 2016 06:33:08 +0000 >Subject: [PATCH] Bug 17211: Remove use of onclick from OPAC fines page > >To test: >1) Set the EnablePayPalOpacPayments syspref to Allow and the >PayPalSandboxMode to the appropriate mode >2) Go to OPAC fines >3) Confirm clicking the PayPal image link works the same before and >after the patch (opens pop up window) > >Sponsored-by: Catalyst IT >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt >index e38b10d..4268c33 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt >@@ -143,7 +143,7 @@ > <div class="control-group"> > <label class="radio"> > <input type="radio" name="payment_method" id="payment_method-paypal" value="paypal" checked="checked"> >- <!-- PayPal Logo --><a href="https://www.paypal.com/webapps/mpp/paypal-popup" title="How PayPal Works" onclick="javascript:window.open('https://www.paypal.com/webapps/mpp/paypal-popup','WIPaypal','toolbar=no, location=no, directories=no, status=no, menubar=no, scrollbars=yes, resizable=yes, width=1060, height=700'); return false;"><img src="https://www.paypalobjects.com/webstatic/mktg/logo/AM_SbyPP_mc_vs_dc_ae.jpg" border="0" alt="PayPal Acceptance Mark"></a><!-- PayPal Logo --> >+ <!-- PayPal Logo --><a href="https://www.paypal.com/webapps/mpp/paypal-popup" title="How PayPal Works" class="paypal"><img src="https://www.paypalobjects.com/webstatic/mktg/logo/AM_SbyPP_mc_vs_dc_ae.jpg" border="0" alt="PayPal Acceptance Mark"></a><!-- PayPal Logo --> > </label> > </div> > <!-- look to the future >@@ -178,6 +178,12 @@ > [% BLOCK jsinclude %] > <script type="text/javascript"> > $( document ).ready(function() { >+ >+ $(".paypal").on("click", function() { >+ window.open('https://www.paypal.com/webapps/mpp/paypal-popup','WIPaypal','toolbar=no, location=no, directories=no, status=no, menubar=no, scrollbars=yes, resizable=yes, width=1060, height=700'); >+ return false; >+ }); >+ > $(".pay-online").removeClass("hidden"); > > $("#amount-to-pay-label").hide(); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17211
:
54969
|
54976
|
55282