Bugzilla – Attachment 54996 Details for
Bug 17152
Duplicating a subfield should not copy the data
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF]Bug 17152: Do not copy value when duplicating a subfield
SIGNED-OFFBug-17152-Do-not-copy-value-when-duplica.patch (text/plain), 1.44 KB, created by
Héctor Eduardo Castro Avalos
on 2016-08-29 20:49:32 UTC
(
hide
)
Description:
[SIGNED-OFF]Bug 17152: Do not copy value when duplicating a subfield
Filename:
MIME Type:
Creator:
Héctor Eduardo Castro Avalos
Created:
2016-08-29 20:49:32 UTC
Size:
1.44 KB
patch
obsolete
>From 344b0040add363389c212b864a7918bdc2fa9e84 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 23 Aug 2016 18:15:41 +0100 >Subject: [PATCH] [SIGNED-OFF]Bug 17152: Do not copy value when duplicating a > subfield > >When cataloguing, if you want to duplicate a subfield that is not >empty, the new subfield is created with a copy of data in it. >This is not the case when you duplicate an whole field. The new one is >created with subfields but without data in it. > >Test plan: >Add or edit a bibliographic record >Fill a subfield >Duplicate the subfield >=> Without this patch the value of the input will be copied >=> With this patch the new input will be emptied > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Works as advertised >--- > koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >index c23637f..46e5693 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >@@ -268,6 +268,7 @@ function CloneSubfield(index, advancedMARCEditor){ > id_input = inputs[i].getAttribute('id')+new_key; > inputs[i].setAttribute('id',id_input); > inputs[i].setAttribute('name',inputs[i].getAttribute('name')+new_key); >+ inputs[i].value = ""; > linkid = id_input; > } > // Plugin input >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17152
:
54784
|
54996
|
55078
|
55079
|
55234
|
55276