Attachment 55000 Details for Bug 7677 – Bug 7677: QA followup

[patch] Bug 7677: QA followup

Bug-7677-QA-followup.patch (text/plain), 1.50 KB, created by Matthias Meusburger on 2016-08-30 08:42:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthias Meusburger

Created: 2016-08-30 08:42:54 UTC

Size: 1.50 KB

patch

obsolete

>From 9af35976320191c4a852d1f37ede41e287e557e5 Mon Sep 17 00:00:00 2001
>From: Matthias Meusburger <matthias.meusburger@biblibre.com>
>Date: Tue, 30 Aug 2016 10:41:56 +0200
>Subject: [PATCH] Bug 7677: QA followup
>
> - Fix tests
>---
> t/db_dependent/Serials_2.t |    4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/Serials_2.t b/t/db_dependent/Serials_2.t
>index 961edb3..0775dae 100644
>--- a/t/db_dependent/Serials_2.t
>+++ b/t/db_dependent/Serials_2.t
>@@ -244,18 +244,16 @@ is( C4::Serials::can_show_subscription($subscription_from_another_branch), 1,
> "Without IndependentBranches, renew_subscription cannot show a subscription from another branch"
> );
> 
>-$schema->storage->txn_rollback;
>-
> # GetPreviousSerialid
> my $serialid1 = NewIssue( 1, $subscriptionid_from_my_branch, $biblionumber, 2 );
> my $serialid2 = NewIssue( 2, $subscriptionid_from_my_branch, $biblionumber, 2 );
> my $serialid3 = NewIssue( 3, $subscriptionid_from_my_branch, $biblionumber, 2 );
>-
> is( GetPreviousSerialid( $subscriptionid_from_my_branch ), $serialid2, "get previous serialid without parameter");
> is( GetPreviousSerialid( $subscriptionid_from_my_branch, 1 ), $serialid2, "get previous serialid with 1" );
> is( GetPreviousSerialid( $subscriptionid_from_my_branch, 2 ), $serialid1, "get previous serialid with 2" );
> is( GetPreviousSerialid( $subscriptionid_from_my_branch, 3 ), undef, "get previous serialid with 3, does not exist" );
> 
>+$schema->storage->txn_rollback;
> $dbh->rollback;
> 
> # C4::Context->userenv
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 7677: 16339 | 16425 | 16456 | 20537 | 20538 | 24099 | 24635 | 25980 | 25981 | 25983 | 27774 | 28950 | 28951 | 28952 | 28953 | 29570 | 29571 | 29572 | 34220 | 34221 | 34222 | 34223 | 34665 | 36389 | 36446 | 36448 | 36449 | 36450 | 36451 | 36452 | 36453 | 36679 | 36680 | 36681 | 36682 | 36683 | 42923 | 42924 | 45938 | 45939 | 45940 | 45941 | 45942 | 45943 | 46216 | 47475 | 52010 | 54876 | 55000 | 55323 | 55466 | 55467 | 55468 | 55469 | 55470 | 55471 | 55472 | 55473 | 55474 | 55475