Bugzilla – Attachment 5504 Details for
Bug 6875
de-nesting C4 packages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6875 de-nesting C4::VirtualShelves
Bug-6875-de-nesting-C4VirtualShelves.patch (text/plain), 1.60 KB, created by
Paul Poulain
on 2011-09-21 15:23:44 UTC
(
hide
)
Description:
Bug 6875 de-nesting C4::VirtualShelves
Filename:
MIME Type:
Creator:
Paul Poulain
Created:
2011-09-21 15:23:44 UTC
Size:
1.60 KB
patch
obsolete
>From 9ead07bcd3eb2bd60a27dd87aa8605f4128635df Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Fri, 16 Sep 2011 21:58:30 +0200 >Subject: [PATCH] Bug 6875 de-nesting C4::VirtualShelves > >* C4::Circulation is unused, removing it >* C4::Members used only in ShelfPossibleAction, switching from use to require >* C4::Auth used only in RefreshShelvesSummary, a sub called only in opac-addbybiblionumber.pl script, moving the require inside the sub >--- > C4/VirtualShelves.pm | 8 +++----- > 1 files changed, 3 insertions(+), 5 deletions(-) > >diff --git a/C4/VirtualShelves.pm b/C4/VirtualShelves.pm >index 57b86da..c74ecb3 100644 >--- a/C4/VirtualShelves.pm >+++ b/C4/VirtualShelves.pm >@@ -26,10 +26,7 @@ use warnings; > > use Carp; > use C4::Context; >-use C4::Circulation; > use C4::Debug; >-use C4::Members; >-require C4::Auth; > > use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); > >@@ -466,7 +463,8 @@ sub ShelfPossibleAction { > my $sth = $dbh->prepare($query); > $sth->execute($shelfnumber); > my ( $owner, $category ) = $sth->fetchrow; >- my $borrower = GetMemberDetails($user); >+ require C4::Members; >+ my $borrower = C4::Members::GetMemberDetails($user); > return 0 if not defined($user); > return 1 if ( $category >= 3); # open list > return 1 if (($category >= 2) and >@@ -559,7 +557,7 @@ This function is used in conjunction with the 'Lists' button in masthead.inc. > =cut > > sub RefreshShelvesSummary ($$$) { >- >+ require C4::Auth; > my ($sessionID, $loggedinuser, $row_count) = @_; > my $session = C4::Auth::get_session($sessionID); > my ($total, $totshelves, $barshelves, $pubshelves); >-- >1.7.4.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6875
:
5442
|
5443
|
5496
|
5497
|
5498
|
5499
|
5500
|
5501
|
5502
|
5503
|
5504
|
5505
|
5506
|
5507
|
5508
|
5509
|
5510
|
5511
|
5512
|
7359
|
7360
|
7361
|
7362
|
7363
|
7364
|
7365
|
7652
|
7654
|
7655
|
7656
|
7657
|
7658
|
7770
|
7771
|
7808
|
7844
|
8095
|
8133
|
8134
|
8135