Bugzilla – Attachment 55097 Details for
Bug 17213
Self registration cardnumber is not editable if errors found when form submitted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17213 - Add HTML5 validation to cardnumber field on patron self registration
Bug-17213---Add-HTML5-validation-to-cardnumber-fie.patch (text/plain), 4.35 KB, created by
Nick Clemens (kidclamp)
on 2016-09-01 18:31:03 UTC
(
hide
)
Description:
Bug 17213 - Add HTML5 validation to cardnumber field on patron self registration
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2016-09-01 18:31:03 UTC
Size:
4.35 KB
patch
obsolete
>From 39eb5e9eed408206f8cb541d2d49ed4b3257b7b4 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 29 Aug 2016 10:54:30 +0000 >Subject: [PATCH] Bug 17213 - Add HTML5 validation to cardnumber field on > patron self registration > >To test: >Verify that different values in 'CardnumberLength' system preference >display correctly in the self reigstration form >--- > .../bootstrap/en/modules/opac-memberentry.tt | 19 +++++++++++++++++-- > opac/opac-memberentry.pl | 8 ++++++++ > 2 files changed, 25 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >index 638808f..cafa5d1 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >@@ -133,8 +133,23 @@ > [% IF borrower && !(cardnumber_wrong_length || cardnumber_already_exists) %] > [% borrower.cardnumber %] > [% ELSE %] >- <input type="text" id="borrower_cardnumber" name="borrower_cardnumber" value="[% borrower.cardnumber %]" /> >- [% IF mandatory.defined('cardnumber') %]<span class="required">Required</span>[% END %] >+ [% IF minlength_cardnumber == maxlength_cardnumber %] >+ <input type="text" id="borrower_cardnumber" name="borrower_cardnumber" size="20" value="[% borrower.cardnumber %]" minlength="[% minlength_cardnumber %]" maxlength="[% maxlength_cardnumber %]" /> >+ [% IF ( mandatory.defined('cardnumber') ) %]<span class="required">Required</span>[% END %] >+ <div class="hint">Card number must be exactly [% minlength_cardnumber %] characters.</div> >+ [% ELSIF minlength_cardnumber && maxlength_cardnumber %] >+ <input type="text" id="borrower_cardnumber" name="borrower_cardnumber" size="20" value="[% borrower.cardnumber %]" minlength="[% minlength_cardnumber %]" maxlength="[% maxlength_cardnumber %]" /> >+ [% IF ( mandatory.defined('cardnumber') ) %]<span class="required">Required</span>[% END %] >+ <div class="hint">Card number must be between [% minlength_cardnumber %] and [% maxlength_cardnumber %] characters.</div> >+ [% ELSIF maxlength_cardnumber %] >+ <input type="text" id="borrower_cardnumber" name="borrower_cardnumber" size="20" value="[% borrower.cardnumber %]" maxlength="[% maxlength_cardnumber %]" /> >+ [% IF ( mandatory.defined('cardnumber') ) %]<span class="required">Required</span>[% END %] >+ <div class="hint">Card number can be up to [% maxlength_cardnumber %] characters.</div> >+ [% ELSE %] >+ <input type="text" id="borrower_cardnumber" name="borrower_cardnumber" size="20" value="[% borrower.cardnumber %]" /> >+ [% IF ( mandatory.defined('cardnumber') ) %]<span class="required">Required</span>[% END %] >+ <div class="hint">There is no minimum or maximum character length.</div> >+ [% END %] > [% END %] > </li> > [% END %] >diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl >index 1a5bac4..0058b87 100755 >--- a/opac/opac-memberentry.pl >+++ b/opac/opac-memberentry.pl >@@ -66,6 +66,14 @@ if ( $action eq q{} ) { > > my $mandatory = GetMandatoryFields($action); > >+my ( $min, $max ) = C4::Members::get_cardnumber_length(); >+if ( defined $min ) { >+ $template->param( >+ minlength_cardnumber => $min, >+ maxlength_cardnumber => $max >+ ); >+ } >+ > $template->param( > action => $action, > hidden => GetHiddenFields( $mandatory, 'registration' ), >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17213
:
54970
|
54971
|
55097
|
55449
|
55450
|
55530
|
55531
|
55665
|
55666
|
55667