Bugzilla – Attachment 5512 Details for
Bug 6875
de-nesting C4 packages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6875 C4::Context cleaning
Bug-6875-C4Context-cleaning.patch (text/plain), 1.28 KB, created by
Paul Poulain
on 2011-09-21 15:25:22 UTC
(
hide
)
Description:
Bug 6875 C4::Context cleaning
Filename:
MIME Type:
Creator:
Paul Poulain
Created:
2011-09-21 15:25:22 UTC
Size:
1.28 KB
patch
obsolete
>From 1034e9e486f20dc3a8d687c65fbdda75fcb23b74 Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Sat, 17 Sep 2011 00:58:41 +0200 >Subject: [PATCH] Bug 6875 C4::Context cleaning > >Checking NYTProf in C4::Context, it appears that the /i flag is highly time-consumming >As we don't support anything outside from mysql, returning directly mysql directly > >If in a future version PostgresSQL works, then we will have to update this sub. But if an ORM is introduced, this code will be removed completly anyway >--- > C4/Context.pm | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > >diff --git a/C4/Context.pm b/C4/Context.pm >index 85d1c18..68ed85a 100644 >--- a/C4/Context.pm >+++ b/C4/Context.pm >@@ -237,12 +237,13 @@ sub read_config_file { # Pass argument naming config file to read > # > sub db_scheme2dbi { > my $name = shift; >- >+ # for instance, we support only mysql, so don't care checking >+ return "mysql"; > for ($name) { > # FIXME - Should have other databases. >- if (/mysql/i) { return("mysql"); } >+ if (/mysql/) { return("mysql"); } > if (/Postgres|Pg|PostgresSQL/) { return("Pg"); } >- if (/oracle/i) { return("Oracle"); } >+ if (/oracle/) { return("Oracle"); } > } > return undef; # Just in case > } >-- >1.7.4.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6875
:
5442
|
5443
|
5496
|
5497
|
5498
|
5499
|
5500
|
5501
|
5502
|
5503
|
5504
|
5505
|
5506
|
5507
|
5508
|
5509
|
5510
|
5511
|
5512
|
7359
|
7360
|
7361
|
7362
|
7363
|
7364
|
7365
|
7652
|
7654
|
7655
|
7656
|
7657
|
7658
|
7770
|
7771
|
7808
|
7844
|
8095
|
8133
|
8134
|
8135