Bugzilla – Attachment 55133 Details for
Bug 8995
Show OpenURL links in OPAC search results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8995: Remove useless code
Bug-8995-Remove-useless-code.patch (text/plain), 2.02 KB, created by
Julian Maurice
on 2016-09-02 14:01:38 UTC
(
hide
)
Description:
Bug 8995: Remove useless code
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2016-09-02 14:01:38 UTC
Size:
2.02 KB
patch
obsolete
>From 8576d4f6a5f0d8739c70814cba56ee42b34d167d Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 2 Sep 2016 15:49:22 +0200 >Subject: [PATCH] Bug 8995: Remove useless code > >OpenURL link display is done in XSLT only, so this code is now useless >--- > opac/opac-detail.pl | 14 -------------- > opac/opac-search.pl | 6 +----- > 2 files changed, 1 insertion(+), 19 deletions(-) > >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index 146b5e4..98afe3e 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -1155,18 +1155,4 @@ $template->param( > 'OpacLocationBranchToDisplayShelving' => C4::Context->preference('OpacLocationBranchToDisplayShelving'), > ); > >-# OpenURL >-if (C4::Context->preference('OPACShowOpenURL')) { >- my ($biblio) = GetBiblioItemByBiblioNumber($biblionumber); >- my @itypes = split( /\s/, C4::Context->preference('OPACOpenURLItemTypes') ); >- if (grep /^$biblio->{itemtype}$/, @itypes) { >- $template->param( >- OPACShowOpenURL => 1, >- OpenURLResolverURL => C4::Context->preference('OpenURLResolverURL'), >- OpenURLText => C4::Context->preference('OpenURLText'), >- OpenURLImageLocation => C4::Context->preference('OpenURLImageLocation') >- ); >- } >-} >- > output_html_with_http_headers $query, $cookie, $template->output; >diff --git a/opac/opac-search.pl b/opac/opac-search.pl >index 5a93cc6..67bba53 100755 >--- a/opac/opac-search.pl >+++ b/opac/opac-search.pl >@@ -673,11 +673,7 @@ for (my $i=0;$i<@servers;$i++) { > $res->{'incart'} = 1; > } > >- if (C4::Context->preference('COinSinOPACResults') >- or C4::Context->preference('OPACShowOpenURL')) { >- if (grep /^$res->{itemtype}$/, @OpenURL_itypes) { >- $res->{ShowOpenURL} = 1; >- } >+ if (C4::Context->preference('COinSinOPACResults')) { > my $record = GetMarcBiblio($res->{'biblionumber'}); > $res->{coins} = GetCOinSBiblio($record); > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8995
:
13141
|
22753
|
23625
|
23626
|
23627
|
24087
|
24088
|
24089
|
26899
|
26900
|
26901
|
29357
|
29358
|
29359
|
30385
|
30386
|
30387
|
30388
|
30389
|
30390
|
35747
|
35916
|
40647
|
44639
|
48371
|
48372
|
55131
|
55132
|
55133
|
55134
|
55135
|
55136
|
55882
|
64513
|
64514
|
64515
|
64516
|
64517
|
64518
|
64519
|
64532
|
64533
|
64534
|
64535
|
64536
|
64537
|
64538
|
86483
|
86484
|
86485
|
86486
|
86487
|
86488
|
86489
|
86490
|
86491
|
86492
|
86541
|
86542
|
86557
|
86558
|
86559
|
86601
|
86602
|
86603
|
86604
|
86605
|
86606
|
86607
|
86608
|
86609
|
86610
|
88665
|
88666
|
88667
|
88668
|
88669
|
88670
|
88671
|
88672
|
88673
|
88735
|
88736
|
88737
|
88738
|
88739
|
88740
|
88741
|
88742
|
88743
|
88744
|
89012
|
89013
|
89014
|
89015
|
89120