Attachment 55358 Details for Bug 15758 – Bug 15758: [QA Follow-up] Final touch?

[patch] Bug 15758: [QA Follow-up] Final touch?

Bug-15758-QA-Follow-up-Final-touch.patch (text/plain), 3.38 KB, created by Jonathan Druart on 2016-09-08 15:33:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-09-08 15:33:28 UTC

Size: 3.38 KB

patch

obsolete

>From 04e79db3a564accf7a9171944fc14e0dc685a672 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 31 Aug 2016 14:20:34 +0200
>Subject: [PATCH] Bug 15758: [QA Follow-up] Final touch?
>
>From qa tools:
>reports/cat_issues_top.pl: pod: =over on line 39 without closing =back
>
>Note: qa tools does also report "options_for_libraries: not found" on two
>template includes. Considering this as a false alarm, since the block is
>defined in another include loaded in doc-head-open.
>[1] koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc
>[2] koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc
>
>Found a template where a USE Branches was missing:
>koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>Easy to spot since the libraries combo was empty.
>Tried to find similar occurrences with few greps, but couldn't find any.
>
>I did find duplicate USE Branches though in:
>koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
>This patch removes them.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt        | 1 -
> koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt  | 1 -
> koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt | 1 +
> reports/cat_issues_top.pl                                           | 2 --
> 4 files changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index 5bee89e..4a941a7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -3,7 +3,6 @@
> <title>Koha &rsaquo; Administration &rsaquo; Circulation and fine rules</title>
> [% INCLUDE 'doc-head-close.inc' %]
> [% INCLUDE 'calendar.inc' %]
>-[% USE Branches %]
> <script type="text/javascript">
> //<![CDATA[
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
>index 45e3704..a08e88f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
>@@ -4,7 +4,6 @@
> <title>Koha &rsaquo; Serials &rsaquo; Check expiration</title>
> [% INCLUDE 'doc-head-close.inc' %]
> [% INCLUDE 'calendar.inc' %]
>-[% USE Branches %]
> <script type="text/javascript" language="JavaScript">
> // <![CDATA[
>     /**
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>index 948d8af..76aaabe 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>@@ -1,4 +1,5 @@
> [% USE KohaDates %]
>+[% USE Branches %]
> 
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Serials &rsaquo; [% IF ( modify ) %][% bibliotitle |html %] &rsaquo; Modify subscription[% ELSE %]New subscription[% END %]</title>
>diff --git a/reports/cat_issues_top.pl b/reports/cat_issues_top.pl
>index dd37811..08b1852 100755
>--- a/reports/cat_issues_top.pl
>+++ b/reports/cat_issues_top.pl
>@@ -36,8 +36,6 @@ plugin that shows a stats on borrowers
> 
> =head1 DESCRIPTION
> 
>-=over 2
>-
> =cut
> 
> my $input = new CGI;
>-- 
>2.8.1

Actions: View | Diff | Splinter Review

Attachments on bug 15758: 47746 | 47747 | 47748 | 47749 | 47750 | 47751 | 47752 | 47753 | 47759 | 47760 | 47761 | 47762 | 47763 | 47764 | 47765 | 52723 | 52724 | 52726 | 52727 | 52728 | 52729 | 52730 | 52731 | 52736 | 52788 | 52789 | 52790 | 52791 | 52792 | 52793 | 52794 | 52795 | 52913 | 52914 | 52915 | 52916 | 52917 | 52918 | 52919 | 52920 | 53893 | 53894 | 53895 | 53896 | 53897 | 53898 | 53899 | 53900 | 53997 | 53998 | 53999 | 54000 | 54001 | 54002 | 54003 | 54004 | 54029 | 54030 | 54031 | 54032 | 54033 | 54034 | 54035 | 54036 | 54037 | 54038 | 54039 | 54040 | 54041 | 54042 | 54043 | 54044 | 54861 | 54862 | 54863 | 54864 | 54865 | 54866 | 54867 | 54868 | 54908 | 54909 | 54921 | 54925 | 55061 | 55062 | 55063 | 55064 | 55065 | 55066 | 55067 | 55068 | 55069 | 55070 | 55071 | 55072 | 55073 | 55346 | 55347 | 55348 | 55349 | 55350 | 55351 | 55352 | 55353 | 55354 | 55355 | 55356 | 55357 | 55358 | 55445