Attachment 55384 Details for Bug 17194 – Bug 17194 - When edit record, Button "Z39.50/SRU search" not work

[patch] Bug 17194 - When edit record, Button "Z39.50/SRU search" not work

Bug-17194---When-edit-record-Button-Z3950SRU-searc.patch (text/plain), 1.85 KB, created by Liz Rea on 2016-09-08 23:59:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Liz Rea

Created: 2016-09-08 23:59:19 UTC

Size: 1.85 KB

patch

obsolete

>From 06e43ac70b2034674e26b5b0818237658760d2ed Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 8 Sep 2016 10:11:56 -0400
>Subject: [PATCH] Bug 17194 - When edit record, Button "Z39.50/SRU search" not
> work
>
>Bug 15859 introduced a problem in the basic cataloging editor by
>removing a form field which the Z39.50 search button tries to use when
>triggering the search window pop-up. This patch corrects the error by
>changing where the script looks for the required framework code.
>
>To test, apply the patch and got to cataloging.
>
>- Edit a record which uses the default framework.
>  - Confirm that the Z39.50/SRU search button works correctly to trigger
>    the pop-up window.
>- Repeat the test with a record which uses a different framework.
>
>Signed-off-by: Liz Rea <liz@catalyst.net.nz>
>Working again, great!
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>index 928956b..f44cb2b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>@@ -354,7 +354,8 @@ function Check(){
>  * check if z3950 mandatories are set or not
>  */
> function GetZ3950Terms(){
>- var strQuery="&frameworkcode="+document.forms['f'].Frameworks.value;
>+    var frameworkcode = document.getElementById("frameworkcode").value;
>+    var strQuery="&frameworkcode=" + frameworkcode;
>     var mandatories = new Array();
>     var mandatories_label = new Array();
>     [% FOREACH BIG_LOO IN BIG_LOOP %][% FOREACH innerloo IN BIG_LOO.innerloop %][% FOREACH subfield_loo IN innerloo.subfield_loop %][% IF ( subfield_loo.z3950_mandatory ) %]mandatories.push("[% subfield_loo.id %]");
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 17194: 55343 | 55384 | 55439 | 55461