Bugzilla – Attachment 55385 Details for
Bug 10227
GetMessagingPreferences does not return correct Digest preferences
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10227 : Fix GetMessagingPreferences when digest is possible
Bug-10227--Fix-GetMessagingPreferences-when-digest.patch (text/plain), 1.73 KB, created by
Chris Cormack
on 2016-09-09 01:06:32 UTC
(
hide
)
Description:
Bug 10227 : Fix GetMessagingPreferences when digest is possible
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2016-09-09 01:06:32 UTC
Size:
1.73 KB
patch
obsolete
>From 675c64962bbef9394f36c60fe47ff5ad6452037c Mon Sep 17 00:00:00 2001 >From: Sophie Meynieux <sophie.meynieux@biblibre.com> >Date: Wed, 24 Aug 2016 14:56:54 +0200 >Subject: [PATCH] Bug 10227 : Fix GetMessagingPreferences when digest is > possible > >This bug is a bit tricky to test, as the result is somehow random, depending on the order of rows returned by sql request. You've got to change the preferences several times to see bad results. > >Enable EnhancedMessaging preferences >Set preferences for a borrower or a category. >run misc/cronjobs/advance_notices.pl and look in message_queue table the letter_code of the generated messages. >Change digest selection and do the test again several times > >Without patch, for message where digest is allowed (Advance_Notice, Item_Due), for a borrower or a category with 'wants_digest' selected, GetBorrowerMessagingPreferences returns sometimes letter_code with DGST and sometimes not. > >With the patch, letter_code returned is always correct depending on digest selected or not > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >--- > C4/Members/Messaging.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Members/Messaging.pm b/C4/Members/Messaging.pm >index 51bcdd8..2270c37 100644 >--- a/C4/Members/Messaging.pm >+++ b/C4/Members/Messaging.pm >@@ -72,6 +72,7 @@ ON message_attributes.message_attribute_id = borrower_message_preferences.me > LEFT JOIN message_transports > ON message_transports.message_attribute_id = message_attributes.message_attribute_id > AND message_transports.message_transport_type = borrower_message_transport_preferences.message_transport_type >+AND message_transports.is_digest = borrower_message_preferences.wants_digest > WHERE message_attributes.message_name = ? > END_SQL > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10227
:
54826
|
55385
|
55513