Bugzilla – Attachment 55386 Details for
Bug 12629
Software error when trying to merge records from different frameworks
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12629 - Software error when trying to merge records from different frameworks
Bug-12629---Software-error-when-trying-to-merge-re.patch (text/plain), 1.42 KB, created by
Chris Cormack
on 2016-09-09 01:27:22 UTC
(
hide
)
Description:
Bug 12629 - Software error when trying to merge records from different frameworks
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2016-09-09 01:27:22 UTC
Size:
1.42 KB
patch
obsolete
>From ee7693d8a5b04caf3bb6ff27ead720ad8e661e4f Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 23 Jul 2014 12:43:54 -0400 >Subject: [PATCH] Bug 12629 - Software error when trying to merge records from > different frameworks > >Test Plan: >1) Choose a bib record that has the default framework. >2) Add a second record using that fast add framework. >3) Merge the records; switch to "Using framework: Default", and choose the original record (i.e. the one that had the default framework) as the merge reference. Clicking 'Next' will trigger the error. >4) Apply this patch >5) Repeat steps 1 - 3, no error should occur > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >--- > Koha/Util/MARC.pm | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/Koha/Util/MARC.pm b/Koha/Util/MARC.pm >index 22774b6..63477ea 100644 >--- a/Koha/Util/MARC.pm >+++ b/Koha/Util/MARC.pm >@@ -43,8 +43,11 @@ sub createMergeHash { > foreach my $field (@fields) { > my $fieldtag = $field->tag(); > if ( $fieldtag < 10 ) { >- if ( !defined($tagslib) >- || $tagslib->{$fieldtag}->{'@'}->{'tab'} >= 0 ) >+ if ( >+ !defined($tagslib) >+ || ( defined( $tagslib->{$fieldtag} ) >+ && $tagslib->{$fieldtag}->{'@'}->{'tab'} >= 0 ) >+ ) > { > push @array, { > tag => $fieldtag, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12629
:
29960
|
30007
|
55386
|
55525