Attachment 55433 Details for Bug 17249 – [SIGNED-OFF] Bug 17249: Remove GetKohaAuthorisedValuesFromField

[patch] [SIGNED-OFF] Bug 17249: Remove GetKohaAuthorisedValuesFromField

SIGNED-OFF-Bug-17249-Remove-GetKohaAuthorisedValue.patch (text/plain), 2.00 KB, created by Owen Leonard on 2016-09-09 12:52:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2016-09-09 12:52:33 UTC

Size: 2.00 KB

patch

obsolete

>From 3b2dac122cf345d47c054d975bd5a28312d4c0b9 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 10 Aug 2016 12:10:46 +0100
>Subject: [PATCH] [SIGNED-OFF] Bug 17249: Remove
> GetKohaAuthorisedValuesFromField
>Content-Type: text/plain; charset="utf-8"
>
>Remove the subroutine, it's no longer in used.
>
>Test plan:
>  git grep GetKohaAuthorisedValuesFromField
>should not return any occurrences.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> C4/Koha.pm | 32 --------------------------------
> 1 file changed, 32 deletions(-)
>
>diff --git a/C4/Koha.pm b/C4/Koha.pm
>index b6828c1..3f8a20f 100644
>--- a/C4/Koha.pm
>+++ b/C4/Koha.pm
>@@ -55,7 +55,6 @@ BEGIN {
> 		&GetAuthorisedValues
> 		&GetAuthorisedValueCategories
> 		&GetKohaAuthorisedValues
>-		&GetKohaAuthorisedValuesFromField
>     &GetKohaAuthorisedValuesMapping
>     &GetAuthorisedValueByCode
> 		&GetAuthValCode
>@@ -1133,37 +1132,6 @@ sub GetKohaAuthorisedValues {
>   }
> }
> 
>-=head2 GetKohaAuthorisedValuesFromField
>-
>-Takes $field, $subfield, $fwcode as parameters.
>-
>-If $opac parameter is set to a true value, displays OPAC descriptions rather than normal ones when they exist.
>-$subfield can be undefined
>-
>-Returns hashref of Code => description
>-
>-Returns undef if no authorised value category is defined for the given field and subfield 
>-
>-=cut
>-
>-sub GetKohaAuthorisedValuesFromField {
>-  my ($field, $subfield, $fwcode,$opac) = @_;
>-  $fwcode='' unless $fwcode;
>-  my %values;
>-  my $dbh = C4::Context->dbh;
>-  my $avcode = GetAuthValCodeFromField($field, $subfield, $fwcode);
>-  if ($avcode) {  
>-	my $sth = $dbh->prepare("select authorised_value, lib, lib_opac from authorised_values where category=? ");
>-   	$sth->execute($avcode);
>-	while ( my ($val, $lib, $lib_opac) = $sth->fetchrow_array ) { 
>-		$values{$val} = ($opac && $lib_opac) ? $lib_opac : $lib;
>-   	}
>-   	return \%values;
>-  } else {
>-	return;
>-  }
>-}
>-
> =head2 GetKohaAuthorisedValuesMapping
> 
> Takes a hash as a parameter. The interface key indicates the
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17249: 55176 | 55177 | 55178 | 55179 | 55180 | 55181 | 55182 | 55428 | 55429 | 55430 | 55431 | 55432 | 55433 | 55434 | 56380 | 56381 | 56382 | 56383 | 56384 | 56385 | 56386