Attachment 55451 Details for Bug 16311 – Bug 16311 - Advanced search language limit typo

[patch] Bug 16311 - Advanced search language limit typo

Bug-16311---Advanced-search-language-limit-typo.patch (text/plain), 2.64 KB, created by Andreas Roussos on 2016-09-09 16:49:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Roussos

Created: 2016-09-09 16:49:47 UTC

Size: 2.64 KB

patch

obsolete

>From 1361359f1df766d2dbd90cd26ba3d8101603c057 Mon Sep 17 00:00:00 2001
>From: Andreas Roussos <arouss1980@gmail.com>
>Date: Fri, 9 Sep 2016 19:46:33 +0300
>Subject: [PATCH] Bug 16311 - Advanced search language limit typo
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>In the OPAC -> Advanced Search, the Language drop down menu incorrectly
>lists Romanian as "RomÃ¢n (Romanian)" while the correct value (as reported
>by Barry Cannon) is "RomÃ¢nÄ (Romanian)".
>
>This patch fixes that:
>a) for _new_ installations by modifying
>   installer/data/mysql/mandatory/subtag_registry.sql (loaded by the web
>   installer when koha is installed), and also
>b) for _existing_ installations by adding an atomicupdate file in
>   installer/data/mysql/atomicupdate/
>
>Test plan:
>1) In the OPAC, go to Advanced search (cgi-bin/koha/opac-search.pl).
>2) In the 'Language' drop down menu, observe that the value for Romanian
>   is "RomÃ¢n (Romanian)".
>3) Apply the patch, and run installer/data/mysql/updatedatabase.pl.
>4) Refresh the Advanced search page in the OPAC. Confirm that the patch
>   worked, i.e. the Language drop down menu lists Romanian as
>   "RomÃ¢nÄ (Romanian)" (notice the added 'Ä').
>---
> .../bug_16311-fix_typo_in_OPAC_adv_search_language_drop_down.sql        | 1 +
> installer/data/mysql/mandatory/subtag_registry.sql                      | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
> create mode 100644 installer/data/mysql/atomicupdate/bug_16311-fix_typo_in_OPAC_adv_search_language_drop_down.sql
>
>diff --git a/installer/data/mysql/atomicupdate/bug_16311-fix_typo_in_OPAC_adv_search_language_drop_down.sql b/installer/data/mysql/atomicupdate/bug_16311-fix_typo_in_OPAC_adv_search_language_drop_down.sql
>new file mode 100644
>index 0000000..fd3ae01
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_16311-fix_typo_in_OPAC_adv_search_language_drop_down.sql
>@@ -0,0 +1 @@
>+UPDATE language_descriptions SET description = 'RomÃ¢nÄ' WHERE subtag = 'ro' AND type = 'language' AND lang = 'ro';
>diff --git a/installer/data/mysql/mandatory/subtag_registry.sql b/installer/data/mysql/mandatory/subtag_registry.sql
>index 5dc2af2..d3bbea8 100755
>--- a/installer/data/mysql/mandatory/subtag_registry.sql
>+++ b/installer/data/mysql/mandatory/subtag_registry.sql
>@@ -861,7 +861,7 @@ INSERT INTO language_rfc4646_to_iso639(rfc4646_subtag,iso639_2_code)
> VALUES ( 'ro','rum');
> 
> INSERT INTO language_descriptions(subtag, type, lang, description)
>-VALUES ( 'ro', 'language', 'ro', 'RomÃ¢n');
>+VALUES ( 'ro', 'language', 'ro', 'RomÃ¢nÄ');
> 
> INSERT INTO language_descriptions(subtag, type, lang, description)
> VALUES ( 'ro', 'language', 'en', 'Romanian');
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16311: 55451 | 55452 | 55464