Bugzilla – Attachment 55456 Details for
Bug 17281
Warning when saving subfield structure
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 17281 Warning when saving subfield structure
PASSED-QA-Bug-17281-Warning-when-saving-subfield-s.patch (text/plain), 1.98 KB, created by
Katrin Fischer
on 2016-09-10 07:23:33 UTC
(
hide
)
Description:
[PASSED QA] Bug 17281 Warning when saving subfield structure
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-09-10 07:23:33 UTC
Size:
1.98 KB
patch
obsolete
>From 1d2760b7ac517f8ffa76dcfaa65dee98b979c8b4 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr> >Date: Fri, 9 Sep 2016 08:06:19 +0200 >Subject: [PATCH] [PASSED QA] Bug 17281 Warning when saving subfield structure > >TO TEST: > >1. Home > MARC Framework > Default > Actions > MARC structure >2. On 073 field (for example), click Edit >3. Click on Edit subfield button >4. Click on Save changes >5. Take a look in intranet logs. You find: > Use of uninitialized value in string eq at > ../admin/marc_subfields_structure.pl >6. Apply the patch, and repeat steps 3-5 > => no more warning in log > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > admin/marc_subfields_structure.pl | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/admin/marc_subfields_structure.pl b/admin/marc_subfields_structure.pl >index ea1373e..38e6f24 100755 >--- a/admin/marc_subfields_structure.pl >+++ b/admin/marc_subfields_structure.pl >@@ -285,7 +285,8 @@ elsif ( $op eq 'add_validate' ) { > my $maxlength = $maxlength[$i] ? $maxlength[$i] : 9999; > > if (defined($liblibrarian) && $liblibrarian ne "") { >- unless ( C4::Context->config('demo') or C4::Context->config('demo') eq 1 ) { >+ my $is_demo = C4::Context->config('demo') || ''; >+ if ( $is_demo ne '1' ) { > if (marc_subfield_structure_exists($tagfield, $tagsubfield, $frameworkcode)) { > $sth_update->execute( > $tagfield, >@@ -376,7 +377,8 @@ elsif ( $op eq 'delete_confirm' ) { > } > elsif ( $op eq 'delete_confirmed' ) { > my $dbh = C4::Context->dbh; >- unless ( C4::Context->config('demo') or C4::Context->config('demo') eq 1 ) { >+ my $is_demo = C4::Context->config('demo') || ''; >+ if ( $is_demo ne '1' ) { > my $sth = > $dbh->prepare( > "delete from marc_subfield_structure where tagfield=? and tagsubfield=? and frameworkcode=?" >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17281
:
55394
|
55435
| 55456