Attachment 55473 Details for Bug 7677 – [PASSED QA] Bug 7677: QA followup

[patch] [PASSED QA] Bug 7677: QA followup

PASSED-QA-Bug-7677-QA-followup.patch (text/plain), 1.31 KB, created by Katrin Fischer on 2016-09-10 11:20:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-09-10 11:20:55 UTC

Size: 1.31 KB

patch

obsolete

>From e1a710593ed722bff999d2d955d873ce578b7d16 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Thu, 25 Aug 2016 16:08:45 +0200
>Subject: [PATCH] [PASSED QA] Bug 7677: QA followup
>
>Fix 'unique contraint primary' error when receiving serials
>
>Signed-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>
>---
> Koha/Serial/Item.pm     | 2 +-
> serials/serials-edit.pl | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Serial/Item.pm b/Koha/Serial/Item.pm
>index 3509b3d..c3286a5 100644
>--- a/Koha/Serial/Item.pm
>+++ b/Koha/Serial/Item.pm
>@@ -39,7 +39,7 @@ Koha::Serial::Item - Koha Serial Item Object class
> 
> =cut
> 
>-sub type {
>+sub _type {
>     return 'Serialitem';
> }
> 
>diff --git a/serials/serials-edit.pl b/serials/serials-edit.pl
>index 12efa67..2bff94b 100755
>--- a/serials/serials-edit.pl
>+++ b/serials/serials-edit.pl
>@@ -257,7 +257,7 @@ if ( $op and $op eq 'serialchangestatus' ) {
>             my $previous = GetPreviousSerialid($subscriptionids[$i]);
>             if ($previous) {
> 
>-                my $serialitem = Koha::Serial::Items->find( $previous );
>+                my $serialitem = Koha::Serial::Items->search( {serialid => $previous} )->next;
>                 my $itemnumber = $serialitem ? $serialitem->itemnumber : undef;
>                 if ($itemnumber) {
> 
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 7677: 16339 | 16425 | 16456 | 20537 | 20538 | 24099 | 24635 | 25980 | 25981 | 25983 | 27774 | 28950 | 28951 | 28952 | 28953 | 29570 | 29571 | 29572 | 34220 | 34221 | 34222 | 34223 | 34665 | 36389 | 36446 | 36448 | 36449 | 36450 | 36451 | 36452 | 36453 | 36679 | 36680 | 36681 | 36682 | 36683 | 42923 | 42924 | 45938 | 45939 | 45940 | 45941 | 45942 | 45943 | 46216 | 47475 | 52010 | 54876 | 55000 | 55323 | 55466 | 55467 | 55468 | 55469 | 55470 | 55471 | 55472 | 55473 | 55474 | 55475